Skip to content

Close three text gaps left after #80 - #82

Merged
DocksDocks merged 2 commits into
mainfrom
81-close-three-text-gaps-left-after-80
Oct 19, 2026
Merged

DocksDocks merged 2 commits into
mainfrom
81-close-three-text-gaps-left-after-80

Conversation

@DocksDocks

Copy link
Copy Markdown
Owner

What and why

Three text gaps in the plan-lifecycle plugin remained after #80:

  • yolo Commits item 2 removed a temporary worktree without git worktree prune. Landing step 9 and the repository teardown rule include it.
  • yolo Red baseline did not say what a run records when a review fix changes a spec assertion. tdd-workflow asks to escalate a wrong test to the user, but a yolo run asks only the merge question. New item 5: run the changed test red against the code before the fix, and record a Red baseline, step <id>, review round <r> line. Item 4 now says that its record replaces the escalation.
  • The contract advice list named only the placeholder, but the helper also advises when Research is empty. The Close yolo, contract, and helper gaps from #78 #79 code review reported this as LOW.

Review order

  1. plugins/plan-lifecycle/skills/productivity/yolo/SKILL.md
  2. plugins/plan-lifecycle/skills/productivity/plan-manager/references/plan-contract.md

Verification

  • node scripts/ci.mjs --plugin plan-lifecycle passed on each commit.
  • A fresh read-only agent got the Close yolo, contract, and helper gaps from #78 #79 trial situation, in which a review fix changed a spec assertion. It answered from item 5, and it found no conflict with tdd-workflow. It also found that the line format used <k> twice, and the commit fixes that.
  • Code review passed in round 1 with one LOW finding: item 5 does not cover a test-only change that already passes before the fix. The finding is in the review comment on Close three text gaps left after #80 #81.
  • Plugin versions are unchanged. scripts/release.mjs bumps them after the merge.

Closes #81

Commits item 2 removed a temporary worktree without git worktree prune,
unlike Landing and the repository teardown rule. Red baseline item 4 did
not say what a review fix that changes a spec assertion records, and
tdd-workflow asks to escalate a wrong test to the user. A yolo run now
records the reason, runs the changed test red before the fix, and adds a
review-round Red baseline line; that record replaces the escalation.

Refs #81
The helper prints "Research is not filled after drafting." for an empty
Research section too, but the contract named only the placeholder. The
#79 code review reported the mismatch as LOW.

Refs #81
@DocksDocks DocksDocks linked an issue Oct 19, 2026 that may be closed by this pull request
@DocksDocks
DocksDocks merged commit c1d413a into main Oct 19, 2026
5 checks passed
@DocksDocks
DocksDocks deleted the 81-close-three-text-gaps-left-after-80 branch October 23, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close three text gaps left after #80

1 participant