审查+修复:v2 SOLID(DRY/OCP/DIP/LSP/迪米特)#13
Merged
Merged
Conversation
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 22, 2026
Rebased onto main@522d799 (post #17). Platform/SDK only: config client withModuleId; service routes assertModulePermission; review doc. Co-authored-by: Cursor <cursoragent@cursor.com>
Tanya7z
force-pushed
the
cursor/v2-solid-review-f73b
branch
from
July 22, 2026 06:49
8a8a60a to
6197955
Compare
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
审查准则升级
此后审查强制套用 DRY · OCP · DIP · LSP · Law of Demeter。本 PR 对当前 main@c559ab4 做 SOLID 补充审查,并直接修两处高置信、可验证的违规。
已修复
?moduleId=(鉴权只认 query)sapi/config/client.tsservice:<name>权限门(tx.call 有)routes/service-routes.ts报告
docs/reviews/v2-solid-principles-review.md— 含仍未修的 BLOCKER(DIP: host 不注入 token; 三抽屉共享 authToken; land-gui 越界)与 MAJOR/MINOR 清单。与前序审查关系
功能级 BLOCKER 修复见此前 PR #3;本 PR 专盯设计原则。
Made with Cursor