Repository navigation
fix(ops): matrix check names contain commas - #29
Merged
Merged
Conversation
Matrix check names contain commas, e.g. `build (platform=macOS, macos, OrzMC-local)`. enable-ai-gate.sh joined the derived contexts with commas and split them again for the JSON body, so OrzMCApp ended up requiring five bogus checks (`build (platform=macOS`, `macos`, ...) that can never report — a permanent merge block. - carry contexts as newline-separated internally - add --contexts-file for names with commas - document the limitation of --contexts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
实测发现：
enable-ai-gate.sh用逗号拼接/拆分检查名，而 matrix 检查名本身就带逗号：结果 OrzMCApp 的
ai-gate被写入了 5 个永远不会上报的检查名（永久阻塞）。已在线修复 OrzMCApp（改为split）与 OrzPythonMC（改为正确的 3 个名字），并：--contexts-file（每行一个检查名）；--contexts仅用于不含逗号的简单名字。