Skip to content

fix(ops): matrix check names contain commas #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangzhizhou merged 1 commit into from
Nov 10, 2026
Merged

fix(ops): matrix check names contain commas #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions scripts/enable-ai-gate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
#
# Usage:
# bash scripts/enable-ai-gate.sh <owner/repo> [more...] [options]
# --contexts "a,b" explicit check contexts
# --contexts "a,b" explicit check contexts (simple names only)
# --contexts-file FILE explicit check contexts, one per line (matrix names)
# --approvals N required approvals (default 0)
# --strict require branches to be up to date (default off)
# --dry-run print what would change
Expand All @@ -25,7 +26,8 @@ DRY=0

while [ $# -gt 0 ]; do
case "$1" in
--contexts) CONTEXTS="${2:-}"; shift 2 ;;
--contexts) CONTEXTS="${2:-}"; shift 2 ;; # comma-separated; matrix names with commas: use --contexts-file
--contexts-file) CONTEXTS="$(cat "${2:-}")"; shift 2 ;;
--approvals) APPROVALS="${2:-0}"; shift 2 ;;
--strict) STRICT="true"; shift ;;
--dry-run) DRY=1; shift ;;
Expand Down Expand Up @@ -109,7 +111,7 @@ PYEOF

apply_checks() {
local repo="$1" branch="$2" contexts="$3" json_contexts rs_id body
json_contexts=$(printf '%s' "$contexts" | python3 -c 'import json,sys; print(json.dumps([c.strip() for c in sys.stdin.read().split(",") if c.strip()]))')
json_contexts=$(printf '%s' "$contexts" | python3 -c 'import json,sys; print(json.dumps([c.strip() for c in sys.stdin.read().splitlines() if c.strip()]))')

if gh api -X PUT "repos/$repo/branches/$branch/protection/required_status_checks" \
--input - >/dev/null 2>&1 <<JSON
Expand Down Expand Up @@ -150,11 +152,11 @@ apply_repo() {
else
if [ -z "$contexts" ]; then contexts=$(existing_classic_contexts "$repo" "$branch" || true); fi
if [ -z "$contexts" ]; then
contexts=$(pr_contexts "$repo" | grep -Ev "$NOISE" | sort -u | paste -sd, - || true)
contexts=$(pr_contexts "$repo" | grep -Ev "$NOISE" | sort -u | paste -sd '\n' - || true)
valid_contexts "$contexts" || contexts=""
fi
if [ -z "$contexts" ]; then
contexts=$(head_contexts "$repo" "$branch" | grep -Ev "$NOISE" | sort -u | paste -sd, - || true)
contexts=$(head_contexts "$repo" "$branch" | grep -Ev "$NOISE" | sort -u | paste -sd '\n' - || true)
valid_contexts "$contexts" || contexts=""
fi
if [ -n "$contexts" ]; then
Expand Down
Loading