Repository navigation
ci: gate PRs on focused cargo test packages (H4) - #24
Conversation
Run a practical lib+integration cargo test matrix through Nix localCi/lint so unit regressions cannot merge on typecheck alone. Nested Wayland e2e scripts stay outside the default PR gate.
ElSargo
left a comment
There was a problem hiding this comment.
Brood QA review
Checked: diff/view; CI 35148206350; audit H4.
Code: Sensible H4 gate. Adds unitTestCheck (craneLib.cargoTest) over a focused package matrix with --lib --tests and --test-threads=2, wired into lintCheck, interactive .#lint, and cache-ci. Nested Wayland e2e correctly kept out. Expansion gaps (brood-capsuled host_smoke, launch/dmabuf) documented in-PR.
CI: FAILURE — runner ENOSPC unpacking rustc/Nix deps. Cannot validate the new gate on GHA until disk pressure clears. Author claims 675 local cargo tests + nix dry-run.
Desktop verify: N/A (CI-only).
Residual / merge: Merge blocker is green CI for this PR and confirming unitTestCheck actually executes in Actions (not just eval). Prefer landing before/with product fix PRs so their new tests become gated. No code objection from review.
— Brood QA
ElSargo
left a comment
There was a problem hiding this comment.
Brood QA review — PR #24 (H4 focused cargo test gate)
Verdict
Approve (content). CI red is infra ENOSPC, not a regression in this diff.
What looks good
- Closes audit H4: default PR lint no longer typecheck-only.
unitTestCheckviacraneLib.cargoTestwith--locked+ focused-pset,--lib --tests,--test-threads=2(documentedbrood-wasmflake mitigation).- Wired through
lintCheck/checks.*.lint, interactivenix run .#lint, andcache-ci. - Matrix matches workspace packages that are meant to be gated;
brood-capsuled/brood-launch/brood-dmabufexclusions are intentional and documented. - Nested Wayland e2e correctly left out of the default gate.
CI
Failed run https://github.com/ElSargo/manifold/actions/runs/35148206350 — No space left on device while unpacking rustc. Treat as runner disk, not a test matrix bug. Re-run after cleanup.
Local checks (this review)
nix eval/nix derivation show .#lintCheck—unitTestCheckis a hard dep of lint.nix build .#lint— embeddedcargo testline matches the PR matrix.- Did not run full
nix build .#unitTestCheckhere (disk).
Notes for merge
- Expect a
nix/packages.nixconflict with PR #25 (same insert region). Rebase the second of the two. - Residual risk: gate increases CI store pressure (same ENOSPC class). Not a reason to block this PR.
Oliver
No code blockers. Infra: free CI disk / re-run before relying on a green check.
Summary
nix run .#ci→checks.*.lint) now builds a focusedcraneLib.cargoTestderivation (unitTestCheck) so unit/integration regressions cannot merge on typecheck alone.brood-protocol,brood-ipc,brood-transport,brood-wasm,brood-layout,brood-plugin-sdk,brood-keybindings,brood-theme,brood-package-contract,brood-graphics,brood-computer-use,brood-profiler,brood-wayland-drop,bmux,brood-cli,brood-remote,broodd,brood-client.tools/test-*-nested.sh) is not part of this gate.nix run .#lintandcache-cifor local/CI cache parity.How to verify locally
Residual gaps / expansion path
brood-capsuled:--libpasses; full package test blocked byhost_smokeneeding missingCARGO_BIN_EXE_brood-capsuled.brood-launch/brood-dmabuf: no meaningful tests yet.--test-threads=2avoids an intermittentbrood-wasmfacet_executorflake under high concurrency.Test plan
cargo testmatrix above: 675 tests passed (--lib --tests,--test-threads=2)nix eval/ dry-run for.#unitTestCheckand.#checks.*.lintnix build .#lintand confirm expandedcargo testline inbrood-lintnix run .#ci)