Repository navigation
ci: clippy first-party WASM plugins in default lint gate (H5) - #25
Conversation
ElSargo
left a comment
There was a problem hiding this comment.
Brood QA review
Checked: diff/view; CI 35149558447; audit H5.
Code: Correct H5 approach. pluginClippyCheck loops 18 first-party plugins with cargo clippy --manifest-path … --target wasm32-unknown-unknown --locked --lib, wired into lint/cache-ci. Explicitly no -D warnings yet; --lib not --all-targets justified (wasm test/host paths). neovim-runtime correctly out of scope.
CI: FAILURE — runner ENOSPC. Cannot confirm the new clippy derivation on GHA yet. Author reports host loop + nix build .#pluginClippyCheck green.
Desktop verify: N/A (CI-only).
Residual / merge: Follow-ups remain (warnings deny, unwrap policy in plugins, all-targets where feasible). Land after CI disk relief proves the gate. May stack with #24 in nix/packages.nix — expect conflict.
— Brood QA
ElSargo
left a comment
There was a problem hiding this comment.
Brood QA review — PR #25 (H5 plugin WASM clippy gate)
Verdict
Approve (content). CI red is infra ENOSPC, not a plugin clippy failure.
What looks good
- Closes audit H5: first-party
plugins/*are independent empty-[workspace]crates and were invisible to rootcargo clippy --workspace. - Gates all 18 Cargo-based plugins for
wasm32-unknown-unknownwith--locked --lib. - Correctly omits
plugins/neovim-runtime(noCargo.toml). - Vendoring path matches existing guest builds (
guestSrc+wasmCargoVendorDir+ crane vendored-deps hook). - Toolchain includes clippy + wasm32 targets via
rustToolchainWithTools. - Conservative first gate: no
-D warnings,--libonly — avoids false fails from known warnings and host-only test paths. - Wired into
lintCheck/checks.*.lint,nix run .#lint, andcache-ci.
CI
Failed run https://github.com/ElSargo/manifold/actions/runs/35149558447 — No space left on device unpacking rust-std (wasm). Infra, not this diff. Re-run after disk cleanup.
Local checks (this review)
nix eval/nix derivation show .#lintCheck— lint hard-depends onbrood-plugin-clippy.- Spot-checked all 18 plugins: empty
[workspace],Cargo.lockpresent, list aligns with vendor lockfiles. - Did not run full
nix build .#pluginClippyCheckhere (disk).
Notes for merge
nix/packages.nixwill conflict with PR #24; rebase whichever lands second.- Follow-ups (optional, not blocking):
-D warnings, per-crate unwrap denies, eventually--all-targetswhere wasm-clean.
Oliver
No code blockers. Infra: free CI disk / re-run. Coordinate merge order with #24.
Plugins are independent Cargo workspaces and were invisible to root cargo clippy --workspace. Run cargo clippy --lib for wasm32 over all plugins/*/ crates in lintCheck / nix run .#lint without -D warnings.
3ad3b2a to
84ede44
Compare
Summary
plugins/*crates declare empty[workspace]and are not root workspace members, so rootcargo clippy --workspacenever linted product UI (session-switcher, keybindings, default-workspace, etc.).pluginClippyCheck(Nix/crane-style guest src + vendored plugin lockfiles) that runs:cargo clippy --manifest-path plugins/<name>/Cargo.toml --target wasm32-unknown-unknown --locked --libover all 18 first-party plugins.
checks.*.lint/lintCheck, interactivenix run .#lint, andcache-ci.-D warningson this first gate — build fails on errors only. Unwrap/deny tightening is a follow-up.Plugins gated
coding-agent,component-runtime-io,component-workspace-watch,default-workspace,diff-viewer,inbox,keybindings,neovim-client,neovim-files,picker,resize-proof,session-switcher,status-bar,terminal-session,terminal-ui,theme-switcher,workspace-file-log,worktree-manager(
plugins/neovim-runtimehas noCargo.toml/ is out of scope.)How to verify locally
Residual gaps / allowlist choices
--libonly (not--all-targets): several plugins' test / host-only paths fail to compile for wasm32 (e.g.worktree-managerunix symlink helpers;default-workspacecustompanic_implvs std when tests pull inserde_json).-D warnings: existing Clippy warnings (e.g.too_many_arguments,if_same_then_else) are allowed so the gate lands without a multi-kLOC cleanup.expectdeny policy is still not applied inside plugins — gradual per-crate lints are follow-up.runtimes/*remain out of this gate..cargo/config.tomlmold linker left alone (wasm32 path unaffected).Test plan
cargo clippy … --libover all 18 plugins: green (warnings only)nix build .#pluginClippyCheck: green (result/passed)nix eval/ show-derivation:lintCheckdepends onbrood-plugin-clippynix run .#ci)