Repository navigation
Correlate backend deploy failures with initiating request - #37
Merged
Merged
Conversation
This was referenced Sep 16, 2026
Open
ElSargo
commented
Sep 16, 2026
ElSargo
left a comment
Owner
Author
There was a problem hiding this comment.
Brood QA (static) — code looks good
Verdict: COMMENT LGTM for remit of #31 (deploy failure ↔ initiating request). Not a formal APPROVE (reviewer is ElSargo).
Evidence
- Optional
requestonConnectionFailed, SSH/container failed events, and deploy host messages; wire-compat omits when unset. - Switcher SSH/container submit paths send
requestfromnext_request();ConnectionFailedignores whenpendingis set and does not match, clearspendingonly whenrequestisSome. - Regression test: unidentified/stale failure leaves newer “Deploying…” status; matched failure clears pending and surfaces error.
Residuals (as documented — do not block this PR)
- Superseded deployer threads not cancelled (ignore-only).
Connectedstill does not settlependingby request id; success path correlation remains open follow-up.- Local / some attach-failure notifies still pass
request: None(correctly ignored while a stamped pending deploy is in flight).
CI
FAILED — GHA Nix ENOSPC on build; lint log also surfaces pre-existing shellcheck SC2148 on sourced theme scripts (not introduced here). Not a code blocker for this change.
Stacking
Same session-switcher + ui-concurrency.md stack as #36 / #40. Merge after #36 if both land; expect conflicts.
Desktop verify: not run.
This was referenced Sep 16, 2026
Thread an optional request id from the session switcher through host deploy messages, deployer ready/failed events, and ConnectionFailed so late failures from superseded attempts cannot overwrite newer pending deploy status. Fixes #31
ElSargo
force-pushed
the
fix/deploy-connection-failed-intent
branch
from
September 16, 2026 21:59
c6e9baf to
bcd0ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestonBackendCatalogueMessage::ConnectionFailedand on SSH/container/remote deployHostMessages.ConnectionFailedunless it matches currentpending, and clearspendingonly on match; new submits bumppendingso prior in-flight failures are superseded.docs/frictions/ui-concurrency.md.Fixes #31
Residual risk
Superseded deployer threads are not cancelled; they are only ignored when their failure notification does not match
pending. Success/Connectedstill does not settlependingby request id.Test plan
cargo test -p brood-protocol --lib backend_catalogue— 6 passedcd plugins/session-switcher && RUSTFLAGS='-C linker=cc' cargo test --lib— 45 passedRUSTFLAGS='-C linker=cc' cargo check -p brood-client