Repository navigation
Retain Create/Activate selection until catalogue catches up - #40
Merged
Merged
Conversation
This was referenced Sep 16, 2026
Open
ElSargo
commented
Sep 16, 2026
ElSargo
left a comment
Owner
Author
There was a problem hiding this comment.
Brood QA (static) — code looks good
Verdict: COMMENT LGTM for remit of #33 (Create/Activate selection vs catalogue lag). Not a formal APPROVE (reviewer is ElSargo).
Evidence
- Successful Create/Activate/Rename sets
selected = Some((backend_id, session))even when the row is absent fromsessions(aligns with worktree retain contract). ensure_selectionretains unpublished(backend_id, session_id)realm instead of snapping to an older catalogue row.- Tests: create completion before catalogue; stale catalogue after create keeps realm/selection on new id.
Residuals (acknowledged)
- Native client
select_active_sessioncan still focus before catalogue install; shared commit receipt across completion + catalogue remains future work (related to #30 / #36).
CI
FAILED — GHA Nix ENOSPC. Not a code blocker.
Stacking
Touches session-switcher + ui-concurrency.md with #36 / #37. Land after #36 (and ideally after #37) or expect conflict resolution on both files.
Desktop verify: not run (manual “create then stale catalogue” needs interactive client).
2 of 3 tasks
Align ordinary Create/Activate/Rename selection with the worktree retain-until-catalogue contract, and keep ensure_selection from snapping list selection away from an unpublished realm identity when a delayed catalogue still lacks that row. Fixes #33
ElSargo
force-pushed
the
fix/create-completion-retain-until-catalogue
branch
from
September 16, 2026 22:00
e170437 to
5f0aab0
Compare
ElSargo
added a commit
that referenced
this pull request
Sep 16, 2026
stale_catalogue_after_create needed BackendCatalogueEntry::snapshot_revision introduced by #36.
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedto the completed identity even when the session row is not yet insessions(same contract as worktree).ensure_selectionto retain an unpublished(backend_id, session_id)realm instead of rebinding to an older catalogue row.docs/frictions/ui-concurrency.md.Fixes #33
Residual risk
Native client
select_active_sessionon Activate/Create success can still focus before catalogue install. A shared commit receipt across completion and catalogue publication remains future work (related to #30).Test plan
cd plugins/session-switcher && RUSTFLAGS='-C linker=cc' cargo test --lib— 46 passed