style: autocorrect rubocop offenses in appengine and jobs samples - #1908
style: autocorrect rubocop offenses in appengine and jobs samples#1908torreypayne wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes parentheses from the system! method definition in several setup scripts and adjusts the indentation of the max_compensation parameter in jobs/V3/filter_search_sample.rb. The review feedback correctly points out that this indentation change introduces a layout inconsistency relative to the sibling min_compensation parameter and suggests a uniform formatting structure for better readability.
| jobs::Money.new currency_code: "USD", | ||
| units: max_unit, | ||
| nanos: 500_000_000 | ||
| ), |
There was a problem hiding this comment.
The auto-correction of max_compensation has introduced a significant layout inconsistency. While max_compensation is now indented with 4 spaces, its sibling argument min_compensation (on line 238) remains indented with 51 spaces.
To maintain readability and consistency, it is highly recommended to format both arguments of jobs::CompensationRange.new uniformly. For example, you can wrap the arguments in standard parentheses and format them like this:
compensation_range = jobs::CompensationRange.new(
max_compensation: jobs::Money.new(
currency_code: "USD",
units: max_unit,
nanos: 500_000_000
),
min_compensation: jobs::Money.new(
currency_code: "USD",
units: min_unit,
nanos: 0
)
)|
Lets also use |
Fixes Rubocop errors reported in presubmit:
Autocorrected via Rubocop CLI (
bundle exec rubocop -a).