Skip to content

style: autocorrect rubocop offenses in appengine and jobs samples #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
torreypayne wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

style: autocorrect rubocop offenses in appengine and jobs samples #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/rails-hello_world/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
2 changes: 1 addition & 1 deletion appengine/standard-static-files/rails/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
2 changes: 1 addition & 1 deletion appengine/static_files/rails/bin/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require "fileutils"
# path to your application root.
APP_ROOT = File.expand_path "..", __dir__

def system!(*args)
def system! *args
system(*args) || abort("\n== Command #{args} failed ==")
end

Expand Down
8 changes: 4 additions & 4 deletions jobs/V3/filter_search_sample.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ def job_discovery_compensation_search project_id:, company_name:, min_unit:, max
domain: "http://careers.google.com"
# Search jobs that pay between min_unit and max_unit (USD/hour)
compensation_range = jobs::CompensationRange.new max_compensation: (
jobs::Money.new currency_code: "USD",
units: max_unit,
nanos: 500_000_000
),
jobs::Money.new currency_code: "USD",
units: max_unit,
nanos: 500_000_000
),
Comment on lines +234 to +237

@gemini-code-assist gemini-code-assist Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The auto-correction of max_compensation has introduced a significant layout inconsistency. While max_compensation is now indented with 4 spaces, its sibling argument min_compensation (on line 238) remains indented with 51 spaces.

To maintain readability and consistency, it is highly recommended to format both arguments of jobs::CompensationRange.new uniformly. For example, you can wrap the arguments in standard parentheses and format them like this:

  compensation_range = jobs::CompensationRange.new(
    max_compensation: jobs::Money.new(
      currency_code: "USD",
      units:         max_unit,
      nanos:         500_000_000
    ),
    min_compensation: jobs::Money.new(
      currency_code: "USD",
      units:         min_unit,
      nanos:         0
    )
  )

@aandreassa aandreassa Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix!

min_compensation: (
jobs::Money.new currency_code: "USD",
units: min_unit,
Expand Down