Skip to content

[tooling] Changelog: kind/internal and kind/epic always exclude an issue, even with a category label - #309

Merged
jesusmpc merged 1 commit into
mainfrom
tooling/GH-308-changelog-excluded-labels
Nov 11, 2026
Merged

jesusmpc merged 1 commit into
mainfrom
tooling/GH-308-changelog-excluded-labels

Conversation

@jesusmpc

Copy link
Copy Markdown
Contributor

Closes #308

Summary

An issue labelled kind/internal or kind/epic is now out of scope for the generated changelog whatever other kind/* labels it has. Before, it was excluded only when no category label (kind/bug, kind/enhancement, ...) was present, so kind/internal + kind/bug still produced a Fixed entry.

  • changelog-from-prs.mjs: the exclusion check no longer depends on the section being guessed; the test that asserted "a real category wins" is inverted, and a case-insensitivity test is added.
  • Excluded issues are still reported as out of scope, never dropped silently, and still count as a closing issue for the "every PR closes an issue" check.
  • Docs and rules updated to match: the changelog skill, AGENTS.md, CONTRIBUTING.md, the two workflow docs, and the changelog-generation spec, design and proposal of the in-flight generate-changelog-from-closing-issues change.

Checks

  • node --test .github/scripts/changelog-from-prs.test.mjs (37 tests)

…sue, even with a category label

An issue with kind/internal or kind/epic is now out of scope for the
generated changelog whatever other kind/* labels it has, instead of only
when no category label is present. Excluded issues are still listed in the
report and still count as a closing issue.

Closes #308

Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
@jesusmpc
jesusmpc requested a review from a team as a code owner November 11, 2026 15:34
@jesusmpc jesusmpc self-assigned this Nov 11, 2026
@jesusmpc jesusmpc added the skip-release Blocks the version bump; exempts a PR from closing an issue label Nov 11, 2026
@jesusmpc
jesusmpc merged commit f99e9ba into main Nov 11, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release Blocks the version bump; exempts a PR from closing an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tooling] Changelog: kind/internal and kind/epic always exclude an issue, even with a category label

1 participant