Repository navigation
[tooling] Changelog: kind/internal and kind/epic always exclude an issue, even with a category label - #309
Merged
Conversation
…sue, even with a category label An issue with kind/internal or kind/epic is now out of scope for the generated changelog whatever other kind/* labels it has, instead of only when no category label is present. Excluded issues are still listed in the report and still count as a closing issue. Closes #308 Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308
Summary
An issue labelled
kind/internalorkind/epicis now out of scope for the generated changelog whatever otherkind/*labels it has. Before, it was excluded only when no category label (kind/bug,kind/enhancement, ...) was present, sokind/internal+kind/bugstill produced a Fixed entry.changelog-from-prs.mjs: the exclusion check no longer depends on the section being guessed; the test that asserted "a real category wins" is inverted, and a case-insensitivity test is added.AGENTS.md,CONTRIBUTING.md, the two workflow docs, and thechangelog-generationspec, design and proposal of the in-flightgenerate-changelog-from-closing-issueschange.Checks
node --test .github/scripts/changelog-from-prs.test.mjs(37 tests)