Repository navigation
ci: keep Claude review subagents in the foreground - #44
Merged
Merged
Conversation
In CI the run ends when Claude's turn ends. The code-review plugin's first step was launched as a background subagent, so Claude ended its turn waiting on it and the job exited before any review happened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pe7k1XG8178GSmRsq1KkAR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With full output on (run 37700704913), the review on #40 showed the real failure: the
code-reviewplugin launched its first-step check as a background subagent, Claude ended its turn to wait for it, and in CI the run ends with the turn, so the job exited "successfully" before any review happened.This tells Claude to run subagents in the foreground and not end its turn until the review is posted.
It can't be tested from a branch:
claude-code-actionrefuses to run a workflow whose contents differ from the default branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pe7k1XG8178GSmRsq1KkAR
Generated by Claude Code