fix: release bounded telemetry claims on completion - #245
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08a81c3721
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (claim, result) | ||
| } | ||
| })) | ||
| .await; |
There was a problem hiding this comment.
Keep telemetry waits off the snapshot refresh loop
When either stats request is slow or reaches the 750 ms timeout, awaiting the whole join_all blocks refresh_cache; because refresh_loop starts its two-second sleep only after that call returns, every affected tick stretches the Docker snapshot cadence to roughly 2.75 seconds plus collection time. This contradicts the two-second cadence relied on in docs/architecture/PROVIDER_SCHEDULING_AND_MODEL_REVISIONS.md and makes all topology and health views staler whenever the stats gateway stalls; retain claim ownership without putting the telemetry timeout on the snapshot scheduler's critical path.
Useful? React with 👍 / 👎.
08a81c3 to
552b083
Compare
Summary
Verification
No contract files changed. Contract tests were not run in this isolated worktree because its dependencies are absent. Rust lint was attempted but the host ran out of disk space while creating a duplicate worktree target.