Repository navigation
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrFnSipitEXUhVySPKfrMR
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrFnSipitEXUhVySPKfrMR
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testify v2.4.3
What this changes
Ships #216 as version 2.4.3, once #217 is merged into
develop:main's release merge brought intodevelop.Release notes
Testify v2.4.3
A bug fix release. If the bot couldn't see or post in the channel you pointed
/announceat, the command failed with an unexpected error and an error reference, and[COMMAND_ERROR] Missing Accesswas logged. Now the bot checks the channel first and tells you, privately and in your own language, exactly which permissions to give it there.npm ciandnpm run build, rebuild the Docker image, or pullghcr.io/kkkermit/testify:2.4.3.🐛 Fixed
/announcefailed with "Missing Access" in a channel the bot couldn't see. The bot's permissions were only checked across the whole server, so a channel that hid itself from the bot's role got through. Discord then refused the post. Now the reply names what's missing, for example: "I need these permissions in #announcements:view channel,send messagesandembed links"./announce,/say,/sticky-message setup,/lottery setup,/giveaway start,/bot-stats-channeland/ticket setup, which also checks that the transcript channel allows Attach Files.🌍 Translations
🧪 Tests
/announcein a channel the bot can't see, for the posting rule itself (including threads, Administrator and a German refusal), and for a panel picker refusing a hidden channel. Four were each confirmed to fail without the fix.npm run checkpasses locally with 4,044 tests; the 30 database suites are skipped there. CI ran every suite, the database suites included, on Windows, and passed on fix: Checked the bot can post in a channel before posting there #216.Full changelog: release/v2.4.2...release/v2.4.3
Why
mainwould release nothing and re-publish the Docker image under2.4.2.How to verify
Before merging:
developreads 2.4.3 in all three package manifests.Testsjob with the database suites.main's release merge is ondevelop, so this pull request shows only fix: Checked the bot can post in a channel before posting there #216 and chore: Bumped the version to 2.4.3 and brought main into develop #217, with no conflict.Docker imagecheck on this pull request to finish green.After merging:
v2.4.3 Testifywith the notes above./announceinto it. It answers privately with the missing permissions, and nothing new is logged aterror./announceposts as before.Checklist
developintomain.npm ci --dry-runaccepts the bumped lockfile.npm run checkpasses locally. The database suites ran on CI, where they passed on fix: Checked the bot can post in a channel before posting there #216.embed()factory.console.*calls.docs/commands.mdis unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01JrFnSipitEXUhVySPKfrMR