Release v2.4.3

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -50,7 +50,7 @@ body:
     id: version
     attributes:
       label: Testify version or commit
-      placeholder: 2.4.2
+      placeholder: 2.4.3
     validations:
       required: true
 

AGENTS.md

@@ -279,7 +279,7 @@ union type, so a mistyped category is a **compile error**. Adding a category the
 | Change a permission or cooldown gate       | `src/core/checks.ts`                                                                |
 | Change how prefix commands parse           | `src/core/prefix.ts` — the only file that knows they exist                          |
 | Build a button/select/modal                | `src/lib/discord/components.util.ts`                                                |
-| Read a channel a select menu picked        | `src/lib/discord/channelPick.util.ts` — one rule for "can the bot post"             |
+| Check the bot can post in a channel        | `src/lib/discord/channels.util.ts` — `missingToPost`, the one rule for it           |
 | Build a Components V2 message              | `src/lib/discord/containers.util.ts`                                                |
 | Build an embed                             | `src/lib/discord/embeds.util.ts` (nothing else may `new EmbedBuilder()`)            |
 | Draw an image card                         | `src/lib/canvas/canvas.util.ts`, then a `*Card.util.ts` beside it                   |
@@ -531,6 +531,14 @@ Rules:
    with its buttons, jobs and help articles. A command, button or event that imports a switchable feature's own
    `src/lib` folder without being declared under it fails `botFeatures.test.ts`.
 
+**A command that posts where it is told checks the bot can post there first.** `botPermissions` is asked of the
+whole server and `isSendable()` only of the channel's type — `'send' in this`, read out of discord.js — so a channel
+the bot cannot see passed both and Discord refused the post with 50001, which reached the reader as an unexpected
+failure. `requirePostable(channel, readerLanguage(interaction), [what the post needs])` refuses first, naming the
+channel and each permission missing (`iNeedIn`). `missingToPost` is the one rule behind it and behind
+`canPostInChannel` and the panels' `pickedChannelId`: View Channel, then Send Messages, or Send Messages in Threads for
+a thread.
+
 **A bounded option is held on every surface.** Discord refuses a slash command's value outside its `min`, `max`,
 `choices` or `maxLength`, but the prefix and the dashboard's runner read text, so `OptionReader` refuses it there
 instead, and a choice typed in any case reads as the declared value. Nothing held the prefix to `min: 1` once, so

dashboard/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@testify/dashboard",
-	"version": "2.4.2",
+	"version": "2.4.3",
 	"private": true,
 	"type": "module",
 	"scripts": {

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "testify",
-	"version": "2.4.2",
+	"version": "2.4.3",
 	"description": "Self-hosted, all-in-one Discord bot in TypeScript: every command works as slash and prefix, with a web dashboard",
 	"main": "dist/index.js",
 	"license": "MIT",

shared/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@testify/shared",
-	"version": "2.4.2",
+	"version": "2.4.3",
 	"private": true,
 	"description": "Types and zod schemas shared by the bot's API and the dashboard.",
 	"license": "MIT",

src/buttons/auditLog.ts

@@ -1,5 +1,6 @@
 import { defineButton } from "@core/button";
 import { UserFacingError } from "@core/errors";
+import { readerLanguage } from "@core/language";
 import { disableAuditLog, getAuditLogConfig, setAuditLogConfig } from "@database/repositories/auditLogRepository";
 import { requireSendable } from "@lib/discord";
 import {
@@ -53,7 +54,7 @@ export default defineButton({
 
 				const [channelId] = interaction.values;
 				if (channelId === undefined) return;
-				await requireSendable(guild, channelId);
+				await requireSendable(guild, channelId, readerLanguage(interaction));
 
 				const fresh = saved.channelId === null && saved.enabled.length === 0 && draft.events.length === 0;
 				await showEditor({ channelId, events: fresh ? [...AUDIT_EVENTS] : draft.events });
@@ -84,7 +85,7 @@ export default defineButton({
 
 			case "save": {
 				if (draft.channelId === null) throw new UserFacingError("Choose a log channel first.");
-				await requireSendable(guild, draft.channelId);
+				await requireSendable(guild, draft.channelId, readerLanguage(interaction));
 
 				const enabled = collapseEnabled(draft.events);
 				await setAuditLogConfig(guild.id, draft.channelId, enabled);

src/commands/economy/lottery.command.ts

@@ -2,6 +2,7 @@ import { PermissionFlagsBits, MessageFlags } from "discord.js";
 import { strings } from "@config/strings";
 import { defineCommand, inGuild, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
+import { readerLanguage } from "@core/language";
 import { type LotteryFrequency } from "@database/models/lottery.schema";
 import { debitWallet, requireAccount } from "@database/repositories/economyRepository";
 import {
@@ -11,7 +12,7 @@ import {
 	intervalFor,
 	saveLottery,
 } from "@database/repositories/lotteryRepository";
-import { embed, reply, successEmbed } from "@lib/discord";
+import { embed, reply, requirePostable, successEmbed } from "@lib/discord";
 import { discordTime, formatNumber } from "@lib/format";
 import { recordsSettings } from "@lib/settings";
 
@@ -115,6 +116,7 @@ export default recordsSettings(
 					if (!channel?.isTextBased() || !channel.isSendable()) {
 						throw new UserFacingError("Pick a text channel I can post the results in.");
 					}
+					requirePostable(channel, readerLanguage(interaction), [PermissionFlagsBits.EmbedLinks]);
 
 					const frequency = (interaction.options.getString("frequency") ?? "weekly") as LotteryFrequency;
 					const basePrizePool = interaction.options.getInteger("base-pool") ?? 0;

src/commands/giveaway/giveaway.command.ts

@@ -1,7 +1,8 @@
 import { PermissionFlagsBits } from "discord.js";
 import { defineCommand, inGuild, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
-import { reply, successEmbed } from "@lib/discord";
+import { readerLanguage } from "@core/language";
+import { reply, requirePostable, successEmbed } from "@lib/discord";
 import { formatDurationLong, parseDuration } from "@lib/format";
 import { deleteGiveaway, endGiveaway, rerollGiveaway, startGiveaway } from "@lib/giveaways";
 
@@ -39,6 +40,7 @@ export default defineCommand({
 				if (!channel?.isTextBased() || !("guild" in channel)) {
 					throw new UserFacingError("Pick a text channel in this server.");
 				}
+				requirePostable(channel, readerLanguage(interaction), [PermissionFlagsBits.EmbedLinks]);
 
 				await startGiveaway(client, guild, {
 					channelId: channel.id,

src/commands/info/botStatsChannel.command.ts

@@ -1,7 +1,8 @@
 import { PermissionFlagsBits } from "discord.js";
 import { defineCommand, inGuild, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
-import { reply, successEmbed } from "@lib/discord";
+import { readerLanguage } from "@core/language";
+import { reply, requirePostable, successEmbed } from "@lib/discord";
 import { postBotStats, removeBotStats } from "@lib/info";
 
 export default defineCommand({
@@ -27,6 +28,7 @@ export default defineCommand({
 			async run(interaction, client) {
 				const channel = textChannelOption(interaction, "channel");
 				if (channel === null) throw new UserFacingError("Pick a text channel I can send messages in.");
+				requirePostable(channel, readerLanguage(interaction), [PermissionFlagsBits.EmbedLinks]);
 
 				await postBotStats(client, inGuild(interaction), channel.id, interaction.user.id);
 

src/commands/moderation/announce.command.ts

@@ -1,7 +1,8 @@
 import { PermissionFlagsBits } from "discord.js";
 import { asMember, defineCommand, inGuild, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
-import { COLOUR_CHOICES, reply, resolveColour, successEmbed } from "@lib/discord";
+import { readerLanguage } from "@core/language";
+import { COLOUR_CHOICES, reply, requirePostable, resolveColour, successEmbed } from "@lib/discord";
 import { announcementMessage, mentionProblem } from "@lib/moderation";
 
 export default defineCommand({
@@ -30,6 +31,7 @@ export default defineCommand({
 		if (!channel?.isTextBased() || !channel.isSendable()) {
 			throw new UserFacingError("Pick a text channel I can send messages in.");
 		}
+		requirePostable(channel, readerLanguage(interaction), [PermissionFlagsBits.EmbedLinks]);
 
 		const mentions = (interaction.options.getBoolean("ping-everyone") ?? false) ? "everyone" : "none";
 		const problem = mentionProblem(channel, inGuild(interaction), asMember(interaction), mentions);

src/commands/moderation/say.command.ts

@@ -2,7 +2,8 @@ import { PermissionFlagsBits } from "discord.js";
 import { strings } from "@config/strings";
 import { defineCommand, inTextChannel, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
-import { embed, reply, successEmbed } from "@lib/discord";
+import { readerLanguage } from "@core/language";
+import { embed, reply, requirePostable, successEmbed } from "@lib/discord";
 import { containsProfanity } from "@lib/moderation";
 
 export default defineCommand({
@@ -29,6 +30,7 @@ export default defineCommand({
 		}
 
 		const asEmbed = interaction.options.getBoolean("as-embed") ?? false;
+		requirePostable(target, readerLanguage(interaction), asEmbed ? [PermissionFlagsBits.EmbedLinks] : []);
 
 		await target.send(
 			asEmbed

src/commands/settings/sticky.command.ts

@@ -1,8 +1,9 @@
 import { PermissionFlagsBits } from "discord.js";
 import { defineCommand, inGuild, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
+import { readerLanguage } from "@core/language";
 import { listSticky, removeSticky, setSticky } from "@database/repositories/stickyRepository";
-import { embed, reply, successEmbed } from "@lib/discord";
+import { embed, reply, requirePostable, successEmbed } from "@lib/discord";
 import { truncate } from "@lib/format";
 
 export default defineCommand({
@@ -46,6 +47,7 @@ export default defineCommand({
 				if (!channel?.isTextBased() || !channel.isSendable()) {
 					throw new UserFacingError("Pick a text channel I can send messages in.");
 				}
+				requirePostable(channel, readerLanguage(interaction), [PermissionFlagsBits.EmbedLinks]);
 
 				const message = interaction.options.getString("message", true);
 				await setSticky(guild.id, channel.id, message, interaction.options.getInteger("cap", true));

src/commands/tickets/ticket.command.ts

@@ -1,8 +1,9 @@
 import { ChannelType, PermissionFlagsBits } from "discord.js";
 import { channelOption, defineCommand, inGuild, roleOption, textChannelOption } from "@core/command";
 import { UserFacingError } from "@core/errors";
+import { readerLanguage } from "@core/language";
 import { deleteTicketSetup, getTicketSetup, saveTicketSetup } from "@database/repositories/ticketRepository";
-import { embed, reply, successEmbed } from "@lib/discord";
+import { embed, reply, requirePostable, successEmbed } from "@lib/discord";
 import { normaliseTicketSetup, publishTicketPanel } from "@lib/tickets";
 
 export default defineCommand({
@@ -37,6 +38,8 @@ export default defineCommand({
 
 				const panelChannel = textChannelOption(interaction, "panel-channel");
 				if (!panelChannel) throw new UserFacingError("Pick a channel I can post the panel in.");
+				const language = readerLanguage(interaction);
+				requirePostable(panelChannel, language, [PermissionFlagsBits.EmbedLinks]);
 
 				const category = channelOption(interaction, "category");
 				if (category?.type !== ChannelType.GuildCategory) {
@@ -45,6 +48,7 @@ export default defineCommand({
 
 				const transcripts = textChannelOption(interaction, "transcripts");
 				if (!transcripts) throw new UserFacingError("Pick a channel I can send transcripts to.");
+				requirePostable(transcripts, language, [PermissionFlagsBits.EmbedLinks, PermissionFlagsBits.AttachFiles]);
 
 				const staffRole = roleOption(interaction, "staff-role", true);
 				if (!staffRole) throw new UserFacingError("Pick the role that should handle tickets.");

src/config/permissionNames.ts

@@ -13,6 +13,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Mitglieder bannen",
 		KickMembers: "Mitglieder kicken",
 		SendMessages: "Nachrichten senden",
+		SendMessagesInThreads: "Nachrichten in Threads senden",
 		EmbedLinks: "Links einbetten",
 		AttachFiles: "Dateien anhängen",
 		ManageWebhooks: "WebHooks verwalten",
@@ -37,6 +38,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Banear miembros",
 		KickMembers: "Expulsar miembros",
 		SendMessages: "Enviar mensajes",
+		SendMessagesInThreads: "Enviar mensajes en hilos",
 		EmbedLinks: "Insertar enlaces",
 		AttachFiles: "Adjuntar archivos",
 		ManageWebhooks: "Gestionar webhooks",
@@ -61,6 +63,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Bannir des membres",
 		KickMembers: "Expulser des membres",
 		SendMessages: "Envoyer des messages",
+		SendMessagesInThreads: "Envoyer des messages dans les fils",
 		EmbedLinks: "Intégrer des liens",
 		AttachFiles: "Joindre des fichiers",
 		ManageWebhooks: "Gérer les webhooks",
@@ -85,6 +88,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Bandisci membri",
 		KickMembers: "Espelli membri",
 		SendMessages: "Invia messaggi",
+		SendMessagesInThreads: "Invia messaggi nei thread",
 		EmbedLinks: "Incorpora link",
 		AttachFiles: "Allega file",
 		ManageWebhooks: "Gestisci webhook",
@@ -109,6 +113,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Банить участников",
 		KickMembers: "Выгонять участников",
 		SendMessages: "Отправлять сообщения",
+		SendMessagesInThreads: "Отправлять сообщения в ветках",
 		EmbedLinks: "Встраивать ссылки",
 		AttachFiles: "Прикреплять файлы",
 		ManageWebhooks: "Управлять вебхуками",
@@ -133,6 +138,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "Leden verbannen",
 		KickMembers: "Leden verwijderen",
 		SendMessages: "Berichten versturen",
+		SendMessagesInThreads: "Berichten versturen in threads",
 		EmbedLinks: "Links insluiten",
 		AttachFiles: "Bestanden bijvoegen",
 		ManageWebhooks: "Webhooks beheren",
@@ -157,6 +163,7 @@ export const PERMISSION_NAMES: Record<TranslatedLanguage, Partial<Record<Permiss
 		BanMembers: "メンバーをBAN",
 		KickMembers: "メンバーをキック",
 		SendMessages: "メッセージを送信",
+		SendMessagesInThreads: "スレッドでメッセージを送信",
 		EmbedLinks: "埋め込みリンク",
 		AttachFiles: "ファイルを添付",
 		ManageWebhooks: "ウェブフックの管理",