Repository navigation
fix(gh-11)!: production hardening, any-DB support, tests + CI - #20
Merged
Merged
Conversation
- run-command and ai-apply need code_actions (unset = local only); wider denylist - debugbar injected only when DigDeep::check() passes - session values and more auth headers redacted - Js::from() in HTML exports and inline handlers; AI text escaped before markup - CDN scripts pinned with SRI - ai_model/ai_provider fall back to defaults when env is unset - AI endpoints probe the laravel/ai trait instead of autoloading agents (501, not fatal) - EXPLAIN uses the right syntax per driver BREAKING CHANGE: outside local, run-command and ai-apply return 403 unless DIGDEEP_CODE_ACTIONS=true. Closes #11, closes #12, closes #13, closes #14, closes #15, refs #7
One QueryAnalyzer::schema() replaces the duplicated sqlite_master/PRAGMA code in the database page and the MCP AnalyzeQueries tool. Closes #5
PHP 8.4/8.5 x Laravel 12/13. Covers the gate, CSRF, code actions, debugbar gating, redaction, export XSS, AI defaults, schema and EXPLAIN. Closes #6
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 39354595 | Triggered | Laravel APP_KEY | 7baa676 | phpunit.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This was referenced Oct 31, 2026
Nejcc
added a commit
that referenced
this pull request
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9 (secure-by-default, CSRF via
webgroup, body redaction, 404). It retargets tomainonce #9 merges.Security
run-commandandai-applyrequirecode_actions. Unset =localonly,DIGDEEP_CODE_ACTIONS=true/falseoverrides. Wider artisan denylist. Together with CSRF from fix!: secure-by-default enablement, CSRF, body redaction, 404 on deny #9, this closes the drive-by request to localhost that could run commands or write PHP.DigDeep::check()passes.Js::from()in the three HTML exports and in inline handlers. The AI suggestion is escaped before markup is added.proxy-authorization,x-xsrf-token,x-csrf-token,x-api-keyandx-auth-tokenheaders.Bugs
ai_model/ai_providerfall back to defaults instead ofnull.class_exists(QueryFixerAgent::class)autoloaded the agent and fataled on the missing trait. OnehasAiSdk()helper (trait_exists) now coversai-suggest,ai-investigateandai-apply, and each returns 501.AnalyzeQueriesuseSchema::getTables/getColumns/getIndexes/getForeignKeys, with the duplicated PRAGMA code removed. EXPLAIN usesEXPLAIN QUERY PLANon SQLite andEXPLAINelsewhere.Tooling (#6)
Pest + Testbench (15 tests), Pint, and a GitHub Actions matrix of PHP 8.4/8.5 × Laravel 12/13.
.gitattributeskeeps tests and CI out of dist archives. The README now matches the code (requirements, config table, security, storage).Testing
vendor/bin/pest: 15 passed on Laravel 13 (Testbench 11, Pest 5) and on Laravel 12 (Testbench 10, Pest 4).vendor/bin/pint --testclean,gitleaksclean.Not in this PR (tracked)
#16 listener leak in Octane/worker mode · #17 size cap / unbounded collectors / prune per write · #18 redact bindings, log context, response bodies · #19 skip streamed responses, sampling.
BREAKING CHANGE: outside
local,run-commandandai-applyreturn 403 unlessDIGDEEP_CODE_ACTIONS=true.Closes #11, closes #12, closes #13, closes #14, closes #15, closes #5, closes #6. Refs #7.