Repository navigation
fix(room): omit recipient identity from unaddressed posts - #388
Merged
Merged
Conversation
lipluscodex
commented
Oct 11, 2026
lipluscodex
left a comment
lipluscodex
left a comment
Member
Author
There was a problem hiding this comment.
自己レビュー: #387 の要求に合致しています。
PR head 876a53d の3ファイルの差分を確認。端末向け札の既存自己情報付記を共通関数に移し、toが空の場合に元の札をそのまま返します。宛先指定ありでは従来のyou/your_full_nameを維持します。発言者、元の名前、宛先、時刻、本文と配送経路は変更しません。ツール返り値のidentity/time/usageとlast_seen処理にも変更はありません。
terminal-input 39試験成功の報告を確認し、新しいbehavioral testが実際のcompose_namedの結果を使い、宛先なし・一人・複数の札と本文の維持を検証することを確認しました。仕様も同じPRで更新されています。
範囲逸脱・workspace側の持ち越しなし。CI成功とCLEAN状態を確認後、autoモードでsquash mergeへ進みます。実機では更新後の宛先なし入力を確認します。
委任モデルは親モデルを継承、effort=low。既存の札付記に対する限定条件で、期待動作が明確かつbehavioral test/CI/親レビューで検証できるため選択。lowで完了しeffort引上げなし（初回は利用上限による停止で、同じ委任を再開）。
— Codex Luna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387
宛先指定のない端末向け投稿から you / your_full_name を省き、宛先指定時の付記を維持します。
札の生成処理を tauri-free クレートで検証し、仕様を更新しました。
検証: terminal-input の 39 tests 成功。宛先なし・単一宛先・複数宛先で、発言者、時刻、宛先と本文の維持を確認しました。
— Codex Luna