Repository navigation
feat(webhook-relay): append a mark-processed prompt with event_id to room notices - #411
Merged
Merged
Conversation
…room notices Every notice the app relays from github-webhook-mcp now carries one English line, `If this is your own operation, mark it processed now: event_id=<id>`, placed just before the URL line (the bridge's summary ends with it) or at the end when there is none. It is added in `Notices::notice`, so signed, unsigned, deadline-expired and drained notices all get it exactly once, and a signed notice still opens with `署名:`. The app itself still marks nothing (#180). ルームの知らせを読んだセッションが、自分の作業の知らせならその場で既読にするよう、知らせそのものに案内の一行を載せる。docs/1-room.md と docs/4-status.md も同じ変更で更新した。 #410 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NYQn8NK3atdbSGNYFKDEjx
liplus-lin-lay
commented
Oct 13, 2026
liplus-lin-lay
left a comment
Member
Author
There was a problem hiding this comment.
自己レビュー(auto モード)。
- 受け入れ条件: 中継される全ての知らせに、自分の操作なら既読にする一行が event_id 付きで一度だけ入る。
Notices::notice()の一か所で付けていて、署名あり・なし・時間切れ・終了時の吐き出しすべてが通る。署名行は後から先頭に付くので一行目のまま。Lay のレビュー(ルーム)でも同じ確認。 - event_id はアプリが
get_eventに渡しているものと同じで、mark_processedにそのまま使える。 - 範囲の逸脱: rustfmt による無関係なテスト行の折り返しのみ。挙動への影響なし。
- 版の種類: patch(中継の文面に一行足すだけ)。
- ワークスペース側の後回し: per-session clone
pullcept-lin-410をマージ後に削除。 - 次: マージ。
— Claude Lin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #410
変更
If this is your own operation, mark it processed now: event_id=<id>を付ける。server/index.jsで確認)。URL が無ければ末尾に足す。crates/webhook-bridgeのprompted()で、Notices::noticeが通す。署名あり・署名なし・読み待ちの期限切れ・ブリッジ終了時のdrainのどれにもちょうど一度付く。署名のある知らせは署名: <名前>が先頭の行のまま。docs/1-room.mdとdocs/4-status.md、src-tauri/src/webhook.rsのモジュール説明を同じ PR で更新。テスト
cargo test(crates/webhook-bridge): 26 件すべて成功。追加したのは、URL の直前に入ること、URL が無いときは末尾、どの知らせにも自分の id で一度だけ付くこと、署名のある知らせの先頭が署名:のままであること。cargo clippy --all-targets -- -D warningsとcargo fmt --checkも通過。— Claude Lin
🤖 Generated with Claude Code
https://claude.ai/code/session_01NYQn8NK3atdbSGNYFKDEjx