Repository navigation
docs: accept SEP 47, backend-owned execution sessions - #589
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
53 files changed ·
|
Record the review in place under Part III as points R1-R17, with the questions for the maintainer. Part I is unchanged. Review status moves to In review with Opus 5.5 (AI) as reviewer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Addressed the Opus 5.5 review in a6a2130, after updating the branch to main at eee57c6 (SEP 46 / #582 is now Final). The response to all 17 findings is in Part III. The original review text is preserved; separately labelled maintainer decisions sit beside R4, R5, R6, R9 and R12. Part I and the roadmap were revised accordingly. John Travers resolved the arbitrations:
Validation passed: This remains a documentation-only Draft, In review. No native build, numerical qualification or fresh benchmark is claimed. The requested maintainer arbitrations are resolved; the revised whole proposal is ready for the next review before acceptance. |
Record that R1-R17 are answered and consistent with the maintainer's decisions, and add six follow-ups (A1-A6): checkpoint representation, device scope of ported host-march cases, SEP 46 Final updates, ledger readings, structural counters and the SEP 0 exception's bookkeeping. Part I is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtLzcRHFYzZjsv6qNk
|
Addressed A1–A6 from the Opus 5.5 re-review in 2c11c68. The individual responses are in Part III; both original reviews and the first response are preserved unchanged. The re-review accepts the R1–R17 responses and says none of these follow-ups reopens a maintainer decision. I checked the remaining claims against the checkpoint writer/reader, field resume, native admission/host-engine paths, device capability table, SEP 46's final report and the benchmark ledger.
Validation passed: No new maintainer arbitration is needed. The proposal remains Draft / In review, pending human review and formal acceptance under SEP 0. |
|
Updated in 2a66238 following John Travers's scope decisions. The SEP remains Draft / In review, pending his reading and explicit acceptance.
The roadmap, current proposal and tracking issue agree. Earlier reviews and responses remain unchanged in Part III, followed by a record of the superseding scope decisions. Checks passed: diff/spelling, SEP validation (342 passed; 3 expected skips), and Sphinx with warnings as errors. No implementation or fresh benchmark was performed. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
John Travers accepted SEP 47 with five decisions taken before implementation: device capabilities keep their per-vendor status (CUDA low-storage is the only new qualification); every periodic statistic is computed natively; the native session owns the monitor's decision state and records, with exact identity on scalar decision logic; the reference session is built independently in phase 2; and #584 is delivered separately by PR #598. Part I also now specifies running checkpoint contents, monitor restoration, the calibration timing probe, groups as sequences of member problems and the A/B/C attribution. The roadmap entry moves to Accepted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwVEY6NQKGaDDptaj9
SEP 47 makes each backend the only owner of a propagation's mutable numerical state and schedule. Python keeps the scientific construction and external services; native exposes its complete session, and the independent NumPy oracle uses a host session in both precisions. MLX is retired early. #346 and #361 are included workstreams.
Status: Accepted by John Travers on 2026-11-09, after two AI reviews (Opus 5.5) and the drafting agent's responses. Before implementation, Opus 5.5 checked Part I against main at
0901bf6f. The maintainer then decided the questions that check raised (Part III, "Maintainer decisions at acceptance"):Delivery uses the recorded SEP 0 exception: a few coherent phase PRs,
feature/sep-0047-<milestone>.Tracks #588; addresses #110's design questions. Accepting the proposal closes no implementation issue.
Validation:
git diff --checkand codespell on the changed files passed.pytest tests/test_seps.py: 342 passed, 3 expected process-SEP skips.poe docsbuilt cleanly with warnings as errors.Documentation only. No native build was changed, and no benchmark or full gate was run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwVEY6NQKGaDDptaj9