Repository navigation
fix: preserve Library position when watched files arrive - #605
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 119470ef94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| JSON.stringify(activeImageScope), | ||
| selectedNodes.join('\u001f'), |
There was a problem hiding this comment.
With Local Visual Search enabled, scroll down through one set of results and run Find Visually Similar on another image. runVisualSimilar replaces semanticResult, but applySemanticResult keeps the sort order at 'relevance' and leaves searchQuery unchanged. Since this signature includes neither the semantic query nor its result identity, the grid now retains the previous scroll offset instead of showing the new highest-ranked matches and pinned source image. Previously, changes to the filtered result endpoints triggered that reset. Include the semantic search identity in the signature while continuing to exclude background file arrivals.
AGENTS.md reference: AGENTS.md:L236-L236
Useful? React with 👍 / 👎.
New files detected by the folder watcher can send the Library back to the first page and reset its scroll while the user is browsing. Let background arrivals update the Library without forcing that navigation.
Base the Library grid reset signature on folder scope, filters and ordering rather than result count and first/last image IDs. Explicit navigation and filter changes still reset the grid.
Scope: App.tsx only.
Validation: scoped git diff --check passed, and the branch diff against origin/main contains only App.tsx. Build, typecheck and automated tests were not run. Manual acceptance remains pending for background arrivals in paginated and infinite grid layouts, plus resets after changing filters or folder scope.