Skip to content

Repair remaining workflow-service payload and contract lint gates - #39

Draft
MrScripty wants to merge 5 commits into
fix/workflow-lint-basics-2026-10-03from
fix/workflow-private-payload-layout-2026-10-03
Draft

MrScripty wants to merge 5 commits into
fix/workflow-lint-basics-2026-10-03from
fix/workflow-private-payload-layout-2026-10-03

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Repair the remaining workflow-service layout and interface lints through five separately reviewed commits. Box the private validated environment request and worker completion outcome, then the public Ready inference projection; group terminal diagnostic inputs and private session-run inputs; name the existing projection tuple and clarify private summary-error variants.

Preserve raw payload fields, validation/admission, borrowed ownership, the original run Instant, timeout/recovery/no-runtime-load behavior, exact errors and downstream scheduler intent JSON. Ready projection construction/owned bindings now use Box, documented as a public Rust source change despite publish=false. Private summary Debug labels change, while all Display strings remain exact. The unused private terminal session argument was removed after verifying its four callers were plain local values.

Root source reviews accepted c2a6e243, 42349ac0, a79c7c43, 66a25e87 and c3df7026. CI explicitly discovers and runs complete validation-owner, worker, projection, terminal, session-execution and task-summary modules with nonzero guards. Earlier exact heads passed 24 validation-owner, 31 worker, 9 task-graph, 7 binding, 12 snapshot and 4 terminal tests; the terminal head's full focused job passed. New session-context and private-name exact-head qualification remains pending at 533a80b.

Stacked on #38. Aggregate CI and the final main-relative whole-diff external review remain required before merge; no blanket Clippy suppression or measured performance claim is introduced.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant