Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair the remaining workflow-service layout and interface lints through five separately reviewed commits. Box the private validated environment request and worker completion outcome, then the public Ready inference projection; group terminal diagnostic inputs and private session-run inputs; name the existing projection tuple and clarify private summary-error variants.
Preserve raw payload fields, validation/admission, borrowed ownership, the original run Instant, timeout/recovery/no-runtime-load behavior, exact errors and downstream scheduler intent JSON. Ready projection construction/owned bindings now use Box, documented as a public Rust source change despite publish=false. Private summary Debug labels change, while all Display strings remain exact. The unused private terminal session argument was removed after verifying its four callers were plain local values.
Root source reviews accepted c2a6e243, 42349ac0, a79c7c43, 66a25e87 and c3df7026. CI explicitly discovers and runs complete validation-owner, worker, projection, terminal, session-execution and task-summary modules with nonzero guards. Earlier exact heads passed 24 validation-owner, 31 worker, 9 task-graph, 7 binding, 12 snapshot and 4 terminal tests; the terminal head's full focused job passed. New session-context and private-name exact-head qualification remains pending at 533a80b.
Stacked on #38. Aggregate CI and the final main-relative whole-diff external review remain required before merge; no blanket Clippy suppression or measured performance claim is introduced.