Skip to content

Box private runtime-selection diagnostic errors - #40

Draft
MrScripty wants to merge 1 commit into
fix/workflow-private-payload-layout-2026-10-03from
fix/runtime-registry-diagnostic-errors-2026-10-03
Draft

MrScripty wants to merge 1 commit into
fix/workflow-private-payload-layout-2026-10-03from
fix/runtime-registry-diagnostic-errors-2026-10-03

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

After workflow-service clears the aggregate Clippy stage, runtime-registry reports five private Result paths returning a 224-byte diagnostic. Box only those private errors and unwrap at the automatic selection vector and resource-budget context adapters. Public API/DTO/JSON, ranking and accounting behavior remain unchanged; only failure paths add allocations.

Tests cover exact valid candidate count boundaries, the 64-bit count-overflow diagnostic JSON, and the full contextualized public resource-overflow payload. CI runs the complete registry crate with its existing successful selection and budget/underflow tests. Root source review accepted frozen e88e208b. Local changed-syntax/whitespace checks passed; hosted tests and aggregate qualification are pending.

Stacked on #39. A separate formatter-only correction is still needed for inherited recent constructor wrapping, alongside sibling frontend audit/a11y fixes in the final integration. Every aggregate gate and the final main-relative external review remain required before merge.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant