Repository navigation
fix(cli): resolve the runtime pack with the desktop publish properties - #156
Merged
Merged
Conversation
A demo's publish moves its restore output to obj/package/ (MicroEngineNativePackage); the runtime pack query ran without that property and read obj/, which a fresh checkout lacks, so every native package job of the nightly validation failed with NETSDK1004.
|
Preview of acff5b4 (candidates demos): https://micro-engine-ax3pniel5-nastmzs-projects.vercel.app |
Owner
Author
|
validate run 43467981690 (the workflow from #157, against this branch, with .NET and native packages selected):
🤖 Addressed by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly validate failure: every native package job stopped with
NETSDK1004("Assets file '.../obj/project.assets.json' not found").Cause
#153 added a step after
dotnet publishthat asks MSBuild which .NET runtime pack the build used (Packaging.RuntimePack).-p:MicroEngineNativePackage=true. In this repository that property moves the restore output toobj/package/(Directory.Build.props).obj/. That folder exists only if something built the project before.0.6.0-alpha.1 ships this bug. It reaches only games whose
Directory.Build.propsmoves the restore output based on the publish properties, the repository's demos included.Change
Packaging.DesktopPublishProperties: one list given to both the publish and the runtime-pack query, so the two can't drift apart. The browser, Android and iOS paths already passed their properties.Directory.Build.propsmovesobj/. The query resolves the pack with the properties and fails without them.## Next releasein the release notes. Production now holds until the next SDK release.Checks (local)
RED: with
games/MeadowRun/objremoved,node packaging/package.mjs MeadowRun --target windows-x64failed with the sameNETSDK1004as CI.GREEN: the same command builds the package, and
packaging/verify.mjspasses it (13/13 captures against the reference renderers).MicroEngine.Cli.Tests: 33 passed, 1 skipped. Site tests: 71/71.version.mjs checkpasses.From a clean
games/NeonRift/obj,node packaging/package.mjs NeonRift --target linux-x64builds the Linux package (built on Windows). It carries the .NET 10.0.15 runtime licences, andbuild-info.jsonsays"dotnet": "10.0.15".Not run: the macOS package, which shares the same code path. A manual validate on this branch (runs 43466403495 and 43466714696) skipped its whole Supported group without building anything, so the package jobs did not run there. That is a separate problem with the workflow, not with this fix. The next nightly on
mainwill build them.🤖 Generated with Claude Code