Repository navigation
fix(ci): run the checks of a manual validation - #157
Merged
Merged
Conversation
Since the nightly prune job was added, a manual run skips it, and the implicit success() of the jobs after resolve looked at prune too: every manual validation skipped its checks. The jobs now name resolve's result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual validate runs skip all their checks: only Resolve runs, and the report fails with "Supported checks: skipped". This has happened since 6ce5e06 (2026-11-05), on every branch and on
maintoo.Cause
prune, which runs only on the nightly schedule (if: github.event_name == 'schedule').resolvehasneeds: prune, and itsif: ${{ !cancelled() }}lets it run whenprunewas skipped.checks,sdkandplatformsneedresolve. Their condition carries GitHub's implicitsuccess(), and that function looks at every job in the dependency chain. A skippedprunetherefore makes it false, and all three were skipped even thoughresolvesucceeded.The nightly was not affected, because there
pruneruns.Change
checks,sdkandplatformsnow name resolve's result:!cancelled() && needs.resolve.result == 'success'.sdkandplatformskeep their selection conditions. The edit is 7 lines plus a comment explaining why.Checks
actionlintpasses..NETand the native packages selected, against the fix(cli): resolve the runtime pack with the desktop publish properties #156 branch: run 43467981690. The Supported group runs. Packages for all four games pass on Windows, Linux and macOS, and so do .NET tests on Linux and Windows. Of the four Android packages, three pass. CourtyardKey for Android built, but on the emulator itstitlescenario got no result in 240 s, while that game's other four scenarios passed. That is the Android emulator, not this change.🤖 Generated with Claude Code