Repository navigation
Fix Waveshare Box V2 volume mapping - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waveshare Box V2 inherited a 60% output ceiling that drove the ES8311 far below its normal output level, leaving playback quiet even at high slider settings. Keep the codec at fixed 0 dB and use ESPHome software attenuation over the full volume range; failed gain or unmute writes keep the amplifier off.
Hardware impact
The change applies to Waveshare Box V2. The reference Voice Pyramid volume mapping remains unchanged. Existing saved percentages produce louder output, so attended testing should start at low volume.
Standalone impact
Volume control remains device-local and works offline. Settings/API formats, prayer history, shared recordings and partition layout are unchanged.
Testing
Automated: 18 UBSan CTests and 107 Python tests passed. Generated configuration checks cover all Waveshare profiles and the reference volume route. All three Waveshare builds passed pinned dependency, partition and capacity inspection; OTA growth is +96 bytes for audio and +80 bytes for display/diagnostics. See the dated build report.
Hardware: attended installation, loudness/distortion, sustained playback, concurrent network/display runtime memory and cold-restart validation remain pending. Automated builds do not establish physical acceptance.
Licensing/media