Repository navigation
Preserve native ImageJ POINT kind and geometry - #13
Merged
Merged
Conversation
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
Native ImageJ POINT encoding and decoding now belong to the existing registered geometry codec family. The archive reader derives native-kind selection from those declarations instead of treating non-POLYLINE input as polygons. All points and fractional XY are retained; sidecar identity is unchanged. Integer and subpixel OVAL geometry is decoded as EllipseShape, with correct native oval writing.
Unsupported kinds/subtypes, missing metadata, empty/nonfinite geometry, malformed one-point FREEHAND input, and mask encoding fail explicitly. No second codec map, legacy reader, OpenHCS-specific decoder, native axis guessing, or scientific-artifact rewrite.
Validation
Integration boundary
This proves native archive behavior, not installed OpenHCS/MCP/rendered-viewer readiness or biological acceptance. The original frozen malformed FREEHAND archives are preserved. The parent dependency SHA and actual isolated viewer workflow will be validated in OpenHCS PR153; materialized-result routing and orthogonal-view controls remain separate unfinished work.
The user explicitly authorized bounded NRA plus lightweight audit scripts and locally tested checkpoints without waiting for optional hosted CI. See docs/plans/native-imagej-point-roi-20260929.md for source, owner, historical failure, validation, and proof limits.
Closes #12. Related: OpenHCSDev/openhcs#134 and OpenHCSDev/openhcs#153.