Skip to content

Fix native POINT reopening and shared source calibration - #153

Merged
trissim merged 7 commits into
mainfrom
fix/mcp-materialized-result-route-20260929
Sep 29, 2026
Merged

trissim merged 7 commits into
mainfrom
fix/mcp-materialized-result-route-20260929

Conversation

@trissim

@trissim trissim commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Delivered checkpoint

Closes #171. Related to #134; this does not close its broader explicit materialized-directory/provenance work.

  • Advance the PolyStore gitlink to merged Preserve native ImageJ POINT kind and geometry PolyStore#13: native ImageJ POINT archives preserve every fractional point and metadata; malformed one-point FREEHAND remains invalid.
  • Extend existing ViewerStreamingSource calibration ownership. Both manual raw image and ROI routes now derive missing calibration from acquisition metadata. Delete the ROI-only method name in place; no compatibility alias or second registry.
  • Preserve explicit anisotropic/relative source-carrier spacing and avoid querying scalar plate defaults for it.
  • Include a tiny explicit synthetic fixture creator and source-backed ownership/live evidence checkpoint.

Verified

41 focused streaming/agent tests passed on source and again against isolated installed wheels. Dependency's 114 ROI/disk/identity tests also passed source and installed earlier.

Actual installed MCP → managed Napari on isolated :90/TCP5691 → image/POINT reopening → exact coordinate/label/component payloads → six individually opened raw-only/result-only/combined screenshots under two numeric contrast windows → public confirmed viewer close. Native raw/POINT XY scale is 0.65 for both, translations zero, camera/axes unchanged, captures 1440×950. Evidence retained under /home/ts/wt/openhcs-live-point-evidence-20260929. Shared packages, desktop :0, and current H002 :90/5690 preserved.

Bounded NRA original-class census joins 31/31 declarations; lightweight before/after census/overlay and source review are recorded. No global FULL detector/raw-record audit, native equivalence theorem, live Fiji or independent biological acceptance is claimed.

Remaining scope

Explicit arbitrary materialization directory inventory, authenticated writer-success/provenance and bounded table inspection continue in a follow-up PR for #134. Orthogonal viewer MCP control remains #152/#154. Original H002 science stays frozen and ambiguous; the synthetic markers are not cell detections. Current shared viewer has an unpublished ViewerWindowGeometry type, so this installed checkpoint is not a claim that its existing process was upgraded.

Hosted CI is deferred under owner instructions; use local tests plus the actual installed live path as this checkpoint's evidence, while respecting repository-enforced merge rules.

@trissim trissim changed the title Draft: native MCP review of explicit materialized results Fix native POINT reopening and shared source calibration Sep 29, 2026
@trissim
trissim marked this pull request as ready for review September 29, 2026 06:29
@trissim
trissim merged commit ed129d8 into main Sep 29, 2026
13 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manual raw image and ROI reopening disagree on acquisition XY scale

1 participant