Skip to content

Fix native POINT reopening and shared source calibration #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 7 commits into from
Sep 29, 2026
Merged

Fix native POINT reopening and shared source calibration #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83ebf67
Draft: native MCP review of explicit materialized results
trissim Sep 29, 2026
e9c767a
docs: record materialized result owner trace and scan resource blocker
trissim Sep 29, 2026
4d83353
docs: record approved route scope and guarded NRA recovery
trissim Sep 29, 2026
f1532c8
docs: publish native codec evidence and held full audit gate
trissim Sep 29, 2026
02d7b05
Integrate merged native POINT codec and installed MCP validation chec…
trissim Sep 29, 2026
a578008
Share acquisition calibration across manual image and ROI streams
trissim Sep 29, 2026
2313ede
Record installed MCP POINT and calibration witness checkpoint
trissim Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/PolyStore
Open in desktop
Submodule PolyStore updated 4 files
+171 −0 docs/plans/native-imagej-point-roi-20260929.md
+5 −10 src/polystore/roi.py
+115 −8 src/polystore/roi_converters.py
+154 −1 tests/test_roi.py
10 changes: 7 additions & 3 deletions openhcs/core/viewer_streaming_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ def source_workspace_projection(self) -> VirtualWorkspaceSourceProjection:
filemanager=self.filemanager,
).projection_or_empty()

def roi_image_metadata(self) -> ImagePayloadMetadata:
"""Return plate-owned physical calibration for ROI pixel coordinates."""
def plate_image_metadata(self) -> ImagePayloadMetadata:
"""Return acquisition-owned calibration for source-pixel coordinates."""
pixel_size = float(
self.microscope_handler.metadata_handler.get_pixel_size(self.plate_path)
)
Expand Down Expand Up @@ -358,6 +358,10 @@ def load_image(
filemanager=self.filemanager,
source_address=source_path,
).metadata(image)
if not metadata.source_voxel_spacing.has_values:
metadata = metadata.with_source_spatial_context_from(
self.plate_image_metadata()
)
return metadata.payload_with(
image_payload_data(image), image_payload_mask(image)
)
Expand Down Expand Up @@ -844,7 +848,7 @@ def stream_rois(
),
).with_item_fields(
StreamImagePayloadMetadataProjector.item_fields(
self.source.roi_image_metadata(),
self.source.plate_image_metadata(),
message_authority.layout.component_order,
)
)
Expand Down
Loading
Loading