Repository navigation
Defer OME-Zarr imports until NGFF operations - #15
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
September 29, 2026 13:39
trissim
added a commit
to OpenHCSDev/openhcs
that referenced
this pull request
Sep 29, 2026
Use the merged PolyStore main commit containing OpenHCSDev/PolyStore#15 and the latest ROI codec fix. Focused local validation: 138 PolyStore Zarr/ROI tests and 20 OpenHCS source/Zarr tests passed.
trissim
added a commit
to OpenHCSDev/openhcs
that referenced
this pull request
Sep 29, 2026
Resolve the PolyStore pointer against merged OpenHCSDev/PolyStore#15. Focused OpenHCS source/Zarr tests pass on the combined tree (20 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Creating PolyStore's storage registry imports
polystore.zarreven for disk-only pipelines. Its top-level NGFF imports bring in OME-Zarr and Dask before the execution server can accept work. This change keeps the Zarr backend registered and configurable, then loads NGFF format/location code only when a Zarr read, write, or metadata operation consumes it. The output format remains a cached value per backend instance.Closes #14.
Evidence
openhcs.runtime.zmq_execution_serverimport: 1.523 → 0.900 seconds;polystore.zarrimport: 0.736 → 0.101 seconds. Three fresh endpoint connections fell from about 1.81 to 1.17 seconds each.total - server compile - server execute) fell 88.976 → 67.294 seconds; all 30 cases improved, median -0.731 seconds. Summed measured total fell 260.928 → 240.582 seconds. Server job timings varied and are not attributed to this import change.The paired OpenHCS benchmark data and figure will be retained in the OpenHCS submodule-update PR stacked on #186.