Skip to content

P197: a done report's measure is its order's Check - #1733

Closed
trissim wants to merge 9 commits into
mainfrom
cn-survey/p197-order-measure
Closed

trissim wants to merge 9 commits into
mainfrom
cn-survey/p197-order-measure

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

CommsOrderDoneTool carries no measure, so a report cannot choose its own. MeasuredClaim is deleted. OrderDelivery.verified now returns what the order's Check printed when Core verified the delivery. DeliverTodo stores that result on DeliveredProblemOrder.printed, and progress_line() (src/agent_comms/todos.py:1031) shows it on the board: P1: Delivered, waiting on install · Check printed '1'. Deliveries keep their recorded shape, so a delivery record from before the split still round-trips unchanged.

Family test: test_done_declares_no_wrong_measure_and_the_board_shows_the_recorded_check_result.

🤖 Generated with Claude Code

MeasuredClaim joins the ProgressClaim family: what a report ran and the
count it printed. CommsOrderDoneTool compares every claim against the
order's declared Check, so a report quoting another command or count is
refused with both shown.

Src-Budget: 31
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 04:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

trissim and others added 8 commits October 19, 2026 00:29
…recorded

Revert MeasuredClaim: it restated the order's Check only to compare it.
OrderDelivery.verified now records what the order's Check printed when
Core verified the delivery, and a delivered order's board line shows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The delivery stays as recorded, so a record from before the split still
round-trips; DeliverTodo carries the printed result to the delivered
order whose board line shows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nted

DeliverTodo's verified delivery is now CheckedCommitDelivery or
CheckedOperationDelivery, carrying printed as its own field; saved
deliveries without a print decode as their declared member and the board
says no print was recorded. No tuple and no empty-string defaults.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Src-Budget: 15
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6 removed)

Src-Budget: 46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trissim

trissim commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

superseded by main; reopen with a rebase if still needed (P197 now lives in #1955)

@trissim trissim closed this Oct 19, 2026
@trissim
trissim deleted the cn-survey/p197-order-measure branch October 20, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants