[trissim]

Outcome

Each behaviour-failure pattern is one BehaviourPattern subclass. Its signature, existing check objects and source citations live on that class. DeclaredFamily / AutoRegisterMeta owns membership; class objects identify patterns, and document headings derive from their declarations. There is no pattern-name roster, identity switch or second registry. docs/agents/behaviour-catalog.md is generated; the equality check rejects any hand edit.

There are 14 pattern declarations: nine existing-check patterns and the five seeded declarations from 1e6e032b2. Adding a pattern is one class and regeneration.

What remained, and what changed

• Merge current main without reviving obsolete commander workflows. Merged a0ef47d8c, then 011084fc5, then 5cdac561d (main advanced during work); no rebase or force-push. Pushed head: 52c6fd36e6a6e0432479cbe852fb9469617a41bc.
• Conflicts: src/agent_comms/commander/{config,judge,order,rules,send_guard,tool_watch}.py, tests/test_commander_problem_orders.py, tests/test_commander_run_rules.py. Preserved main's current owners throughout the commander family and its tests. The PR now changes only the catalog module, generated document and catalog tests. No commander configuration/lifecycle migration remains in this PR; that work has a separate owner in P701: commander commands use explicit root-bound context #1912.
• The catalog used commander wrapper functions as references. That forced a broad unrelated lazy-import rewrite just to generate documentation. It now holds the actual check implementations: PlainText, StorageStrikeTodo.repeats, Todo.struck_on_order, TodoStore.apply, VoidStrikeTodo.apply, OrderCheck.parse, and the printed-count members. NoIntegerPrinted now comes from its actual owner, child_process.
• Removed the forwarding-only verb/tool check distinction and the derived dictionary/list of pattern names. Both checks and coverage render directly from their owners.
• Corrected signatures to match current Core: duplicate storage strikes are deduplicated; hunts are commander records, not strikes on a named problem. Postmortem citations do not pretend that a pending check enforces a failure.
• The five seeded entries remain single declarations. Their enforcement is not on this main: P197 P197: a done report's measure is its order's Check #1733, P198 A strike or send-back cites state the record can check (P198) #1744 and P201 P201: Core ends work on the runtime publication replaced and names work with no open order #1739 are open; P199 P199: InboxBacklog directs a second commander when the unread backlog passes its limit #1750 and P200 P200: DeadProvider standing rule moves a unit off an exhausted provider #1746 closed without merge. The generated catalog says not enforced here, rather than claiming those changes landed. Completing those independent implementations is not claimed by P196.

Ownership/source evidence

Before: catalog imports commander.order; references wrapper functions; import-time commander configuration changes spill across 16 commander/test files. Postmortem coverage materializes a dictionary of lists of pattern-name strings.

After: BehaviourPattern owns section() and catalog(), each leaf owns its facts, the existing declared-family mechanism supplies membership, and coverage walks class references directly. Only tests/test_behaviour_catalog.py imports the catalog module; the module's __main__ is the generation entrypoint.

Used the existing refactor-audit Package/ParsedModule tooling under Python 3.14 for the source census: 383 production modules, 477 test modules, 34 tool modules; no parse omissions. Inspected declarations, imports, field writes, decisions and consumers; all 14 pattern classes declare their own signature/checks/sources. Also parsed all nine installed metaclass_registry modules and read AutoRegisterMeta.__new__ plus Core's _FamilyMeta/DeclaredFamily registration path. Dynamic import binding is not established by this syntax query; this catalog uses direct imports and class references. The initial NRA import lacked tree_sitter in Core's environment, and NRA's own Python 3.12 could not parse Core's syntax; those attempts are not presented as completed scans. The Python 3.14 refactor-audit census had zero omissions. Applicable catalog precedents: MEMB-1, MEMB-4 and AGENT-2.

Reproduce owner/consumer search:

rg -n 'BehaviourPattern|SeedCatalog\(' src tests tools --glob '*.py'

Requested new-case proof

Added only this temporary sixth seeded declaration (there were already nine non-seeded patterns):

class SixthSeedPattern(BehaviourPattern):
    signature = "Throwaway sixth seed: one new declaration appears without editing a roster."
    checks = (CallableCheck(PlainText),)
    sources = (SeedCatalog(999),)

Ran the actual generation entrypoint:

PYTHONPATH=src /home/ts/code/projects/agent-comms/.venv/bin/python -X faulthandler \
  -m agent_comms.behaviour_patterns > docs/agents/behaviour-catalog.md

Exact catalog diff (no registry, consumer or other declaration edit):

@@ -162,3 +162,13 @@ Checked by:
 - not enforced here: P201 (#1739)
 
 Learned from: seed catalog pattern 18 (claude-ai message 1c8729ba0ed7)
+
+## sixth_seed
+
+Throwaway sixth seed: one new declaration appears without editing a roster.
+
+Checked by:
+
+- check in `agent_comms.todos.PlainText`
+
+Learned from: seed catalog pattern 999 (claude-ai message 1c8729ba0ed7)

The seeded-class count became 6. Removed the throwaway class, regenerated and verified both source and generated document exactly matched the pre-experiment versions.

Requested drift proof

Changed only the generated document's first line by hand. Ran:

PYTHONPATH=src timeout 300 /home/ts/code/projects/agent-comms/.venv/bin/python \
  -X faulthandler -m pytest -o addopts='' \
  --basetemp=/home/ts/.cache/agent-scratch/pi-catalog/drift-test \
  tests/test_behaviour_catalog.py::test_behaviour_catalog_members_name_existing_checks_and_generate_the_file -q

Actual failure, exit 1:

> assert (ROOT / "docs/agents/behaviour-catalog.md").read_text() == BehaviourPattern.catalog()
E AssertionError: assert '# Hand-edite...8729ba0ed7)\n' == '# Behaviour ...8729ba0ed7)\n'
E - # Behaviour catalog
E + # Hand-edited catalog (deliberate drift proof)
tests/test_behaviour_catalog.py:21: AssertionError
FAILED tests/test_behaviour_catalog.py::test_behaviour_catalog_members_name_existing_checks_and_generate_the_file
1 failed, 1 warning in 9.42s

Regenerated afterward; no deliberate drift remains.

Final verification

PYTHONPATH=src timeout 300 /home/ts/code/projects/agent-comms/.venv/bin/python \
  -X faulthandler -m pytest -o addopts='' \
  --basetemp=/home/ts/.cache/agent-scratch/pi-catalog/merged-confirm \
  tests/test_behaviour_catalog.py tests/test_declared_family.py -q
# 9 passed, 1 warning in 14.25s

/home/ts/code/projects/agent-comms/.venv/bin/python -m ruff check \
  src/agent_comms/behaviour_patterns.py tests/test_behaviour_catalog.py
# All checks passed!

git diff --check
# clean

The warning is the environment's missing pytest-timeout plugin (Unknown config option: timeout); the requested outer timeout 300 and Python faulthandler were used. No suite-delta claim is used as proof.

The real generator also ran in a fresh process with an empty HOME, outside the checkout, using this branch's source and the existing interpreter. It produced the exact catalog and created no commander configuration or bus. No runtime installation, saved-session modification, provider call or merge of this PR was performed.

Resource checker: /home/ts/bin/agent-resource-check is absent here; used the repository's tools/agent_resource_check.py --assert-headroom. Warnings only (3.3 GiB RAM available, 3.9 GiB /tmp free); tests were serial, bounded and reused installed dependencies. Disposable test output owned by pi-catalog was under /home/ts/.cache/agent-scratch/pi-catalog; removed after completion. Source and PR handoff stayed in /home/ts/wt/pi-catalog--P1.

Assumed:

• P196 completes declarations and deterministic catalog generation, not the independent P197–P201 implementations.
• “Sixth pattern” means a sixth seeded declaration; the branch already had nine additional patterns.
• Seed numbers are external provenance, not runtime pattern identity; class objects own identity and heading strings are derived presentation.
• Current main's commander owners take precedence over this stale branch's import-time migration.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.