Skip to content

P215: preserve original edit clocks through EventTime - #1951

Merged
trissim merged 9 commits into
mainfrom
fix/P215-unrecorded-edit-time
Oct 20, 2026
Merged

trissim merged 9 commits into
mainfrom
fix/P215-unrecorded-edit-time

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

P215: original edit clocks — rebased and ready

Head: 10d3961d700b905768c72f1564672c137bc541e6.
Base: current origin/main, 15ba6edce1925de29273bee9518e8677bfc48f85.
GitHub reports MERGEABLE, non-draft. P283/#2055 remains parked and untouched.

Ownership and behavior

EditCall.at uses the existing EventTime family. Native starts capture their required float timestamp through EventTime. External unjudged reads decode the original generated SQL clock through GeneratedTimestamp (NULL remains UnrecordedEventTime) and the declared tool with its bound call identity. Both selection and count keep undated edits visible. Original live records are untouched; no invented production clock or alternate absence value was added.

Before-edit AST evidence used the existing audit Package parser across Core, tools and tests, with no parse omissions. Dynamic receiver bindings remain outside that static evidence. Retained evidence: /home/ts/.cache/agent-scratch/pi-cn-phase3/p215/.

Rebase resolution

All conflicts were in src/agent_comms/commander/judge.py, at four intermediate commits. Preserved main's Commander-context signatures and calls (ctx.comms, ctx.commander, ctx.held_by, ctx.post) while retaining P215's inherited edit schema and EventTime age/rendering behavior. No deleted module-level commander functions were restored.

There were no conflicts in transcript_events.py or native_tools.py; main's unrelated changes there remain intact. No merge-main commit was published.

Final checks

Background run, shared QA Python, PYTHONPATH=src, -X faulthandler, outer timeout 300, owned scratch basetemp:

tests/test_edit_evidence.py tests/test_turn_digests.py
8 passed, 1 warning in 15.93s
exit 0

The warning is the shared pytest environment's unknown timeout configuration; the outer timeout was active. The first post-rebase run was 6 passed / 2 failed because two test fixtures omitted required native timestamps. The final commit supplies explicit clocks only in those test-owned fixtures; it does not weaken production timestamp requirements or rewrite live history.

git diff --check: exit 0. Checkout clean and head pushed.

Earlier separate ratchets were tools exit 0 and source exit 1 solely permitted SourceLines growth, with no introduced findings. They are historical results, not reruns on this rebased head. The merger owns its current integration checks.

Retained live-proof gap

The earlier actual live-bus rotate printed its selected unit, then exited 1 at the old MergedProblemOrder.serves failure. That original failed trace remains retained; P270's owner subsequently repaired that family on main. No fresh complete rotate pass or installation is claimed by this rebase delivery. The earlier UNKNOWN push/test attempt was inspected, not replayed.

Assumed: this delivery implements direct rebase/test order 4606; P283 stays parked; prior failed evidence is not a current success claim; merger owns rehearsal and installation. Persistent goal remains blocked.

Agent-Comms-Order: 1037ecc19c74

Copilot AI balanced review requested due to automatic review settings October 19, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim marked this pull request as draft October 19, 2026 18:31
@trissim
trissim marked this pull request as ready for review October 19, 2026 19:19
@trissim
trissim marked this pull request as draft October 19, 2026 20:21
@trissim
trissim force-pushed the fix/P215-unrecorded-edit-time branch 3 times, most recently from e546737 to e950837 Compare October 19, 2026 20:50
@trissim
trissim force-pushed the fix/P215-unrecorded-edit-time branch from e950837 to 455b464 Compare October 19, 2026 23:48
@trissim trissim changed the title P215: retain undated edits without invalid float records P215: preserve original edit clocks through EventTime Oct 20, 2026
@trissim
trissim marked this pull request as ready for review October 20, 2026 00:19
@trissim
trissim force-pushed the fix/P215-unrecorded-edit-time branch from 34cf4c3 to 6bee391 Compare October 20, 2026 01:48
@trissim
trissim merged commit 4774fcb into main Oct 20, 2026
0 of 4 checks passed
trissim added a commit that referenced this pull request Oct 20, 2026
@trissim
trissim deleted the fix/P215-unrecorded-edit-time branch October 20, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants