Repository navigation
P215: preserve original edit clocks through EventTime - #1951
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
marked this pull request as draft
October 19, 2026 18:31
trissim
marked this pull request as ready for review
October 19, 2026 19:19
trissim
marked this pull request as draft
October 19, 2026 20:21
trissim
force-pushed
the
fix/P215-unrecorded-edit-time
branch
3 times, most recently
from
October 19, 2026 20:50
e546737 to
e950837
Compare
trissim
force-pushed
the
fix/P215-unrecorded-edit-time
branch
from
October 19, 2026 23:48
e950837 to
455b464
Compare
trissim
marked this pull request as ready for review
October 20, 2026 00:19
trissim
force-pushed
the
fix/P215-unrecorded-edit-time
branch
from
October 20, 2026 01:48
34cf4c3 to
6bee391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P215: original edit clocks — rebased and ready
Head:
10d3961d700b905768c72f1564672c137bc541e6.Base: current
origin/main,15ba6edce1925de29273bee9518e8677bfc48f85.GitHub reports MERGEABLE, non-draft. P283/#2055 remains parked and untouched.
Ownership and behavior
EditCall.atuses the existing EventTime family. Native starts capture their required float timestamp through EventTime. External unjudged reads decode the original generated SQL clock through GeneratedTimestamp (NULL remains UnrecordedEventTime) and the declared tool with its bound call identity. Both selection and count keep undated edits visible. Original live records are untouched; no invented production clock or alternate absence value was added.Before-edit AST evidence used the existing audit Package parser across Core, tools and tests, with no parse omissions. Dynamic receiver bindings remain outside that static evidence. Retained evidence:
/home/ts/.cache/agent-scratch/pi-cn-phase3/p215/.Rebase resolution
All conflicts were in
src/agent_comms/commander/judge.py, at four intermediate commits. Preserved main's Commander-context signatures and calls (ctx.comms,ctx.commander,ctx.held_by,ctx.post) while retaining P215's inherited edit schema and EventTime age/rendering behavior. No deleted module-level commander functions were restored.There were no conflicts in
transcript_events.pyornative_tools.py; main's unrelated changes there remain intact. No merge-main commit was published.Final checks
Background run, shared QA Python,
PYTHONPATH=src,-X faulthandler, outertimeout 300, owned scratch basetemp:The warning is the shared pytest environment's unknown
timeoutconfiguration; the outer timeout was active. The first post-rebase run was 6 passed / 2 failed because two test fixtures omitted required native timestamps. The final commit supplies explicit clocks only in those test-owned fixtures; it does not weaken production timestamp requirements or rewrite live history.git diff --check: exit 0. Checkout clean and head pushed.Earlier separate ratchets were tools exit 0 and source exit 1 solely permitted SourceLines growth, with no introduced findings. They are historical results, not reruns on this rebased head. The merger owns its current integration checks.
Retained live-proof gap
The earlier actual live-bus rotate printed its selected unit, then exited 1 at the old
MergedProblemOrder.servesfailure. That original failed trace remains retained; P270's owner subsequently repaired that family on main. No fresh complete rotate pass or installation is claimed by this rebase delivery. The earlier UNKNOWN push/test attempt was inspected, not replayed.Assumed: this delivery implements direct rebase/test order 4606; P283 stays parked; prior failed evidence is not a current success claim; merger owns rehearsal and installation. Persistent goal remains blocked.
Agent-Comms-Order: 1037ecc19c74