Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Src-Budget: 108
Src-Budget: 113
Checked receipt members compose existing delivery behavior and keep CheckPrinted at the verification owner. Board, goal and done output read its presentation. CommitDelivery and P710 evidence are unchanged. Working source checkpoint; final application verification follows P192.
trissim
force-pushed
the
fix/p197-p192-on-p710
branch
from
October 19, 2026 21:16
6d5e14b to
726c94b
Compare
Carry the destination through the existing caller contract. The director asks AuthorizedAct only for registered human recipients. Act declarations own their verbs; a shared interrogative parser tokenizes once, with no permission-phrase regex roster. Fresh review and normal directive checks remain in force.
Core rechecks a supplied false receipt and stores only the actual print. Authenticated MCP records refused routine questions without sending them, while preserving product, paid-provider, factual and quoted questions and unit messages. Actual CLI/MCP scratch-bus journey also passed.
…stion grammar Remove the duplicate submission-type association; the checked delivery declarations already inherit the submitted type. Keep external English pronouns with the question grammar. Record the P192/P197 feature allocation already declared in draft #1955, without changing the ratchet or its baseline. Src-Budget: 162
Contributor
Author
|
Closing stale draft: no commit since yesterday and nobody has mentioned it on either commander's bus since midnight. Branch kept; reopen with a current owner if the work is still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P192/P197 takeover: rebased onto current main
Head:
1caf61d10e18bb1906b5f055fb33a834b1cfbfbb. Base:b793c7325c99c3a0f721df0ac85978daa3eb2763. Claude-code reassigned #1955 from pi-catalog to pi-toad-list in message 3022. Rebased the existing branch with an explicit old-head lease; subsequent checkpoints were ordinary pushes. This draft now targets main rather than its old P710 stack base. Not merged or installed.Owners and coherent repairs
OrderDelivery.verifiedvalidates and records the actualCheckPrintedin Core.CheckedDeliveryowns that typed measurement. Its commit/operation members compose the existing delivery behavior through inheritance; the duplicatesubmissionclass mapping is deleted. Board, done and goal instructions derive their presentation from the checked Core delivery. A supplied print of 999 is checked again and replaced with the actual 7; each delivery runs its declared check once.DirectorCallerchecks the registered recipient role, and human-directed questions go throughAuthorizedActand its declaration-owned verbs.PermissionQuestionowns external question grammar, including modals and first-person subjects. No caller phrase regex, second verb roster or action-name switch. Product/paid-provider/factual/quoted questions and messages to workers retain their distinct behavior.TurnEvidence, not an alias, so the retained combined check prints the required 7. No production data migration or alternate reader is added.Production diff from pinned main: 346 additions / 67 deletions (net 279), including the inherited P710 changes. The P192/P197 feature allocation already declared in the original PR, Src-Budget: 162, is now present as a commit trailer. Existing inherited allocations remain. The ratchet, baseline and checker configuration are unchanged. No suppression, cast, Any, moved finding or new scanner was added.
Source evidence
Existing refactor-audit Package was used for declarations, imports, writes, branches and consumers. Before: original branch production 381 modules, tests 480, tools 35; main production 381. Those completed roots had zero parse omissions. The first 60-second source census stopped before main's test/tool roots completed; those roots are not claimed as fully enumerated. After the semantic batch: production 381 modules, zero parse omissions. The final turn-class rename changes no class count. Dynamic CLI/dataclass binding and actual C3/codec behavior were confirmed by the application/tests below, not inferred from AST alone.
Fresh actual application journey on this head
Branch source, real commander CLI, authenticated HTTP MCP server, real Comms/registry/Todo/Git/codecs; no fake Core objects, provider calls, production messages or installed-package changes.
The real check counted
class CheckedCommitDeliveryin the delivered source, and a scratch marker confirmed exactly one execution. The pushed feature commit was explicitly confirmed not to be an ancestor of origin/main, so this proves actual branch delivery rather than synthetic merged acceptance.Authenticated requests to the normal connector
serveentrypoint refused all three routine permission questions to a human (register,send,restart), appended no bus message, and returned HTTP 200 with isError=true and Already authorized. A product question to the human and the same send question to a worker succeeded and appended exactly two messages. The service was terminated normally after verification.Actual uncited strike CLI refused with readable
Cite the state ... --commit / --diff / --turn / --process / --runtimetext and retained zero strikes.Checks
git diff --check: clean. All production edits committed/pushed. An owned standalone verification helper is retained untracked at.proof/P197-journey.py; it is not production code or a hidden repair.Receipts under
/home/ts/.cache/agent-scratch/pi-toad-list/:P197-head-src.json,P197-head-tools.json,P197-checked-final-tests.log,P197-head-application.log,P197-head-strike-refusal.log, and source-before/after reports. Owned checkout:/home/ts/wt/pi-toad-list--P197, about 23 MiB. Combined owned scratch/checkouts remain far below 3 GiB. The configured resource helper is absent; checks ran serially and bounded, using existing environments only.Assumed / remaining state
592568a1b8c3. The explicit reassignment authorized this source takeover; commander-only ownership/completion records have not been impersonated or changed by this worker.src/agent_comms introduced
{ "FrozenFieldWrite:src/agent_comms/behaviour_patterns.py": 0, "BannedVocabulary:src/agent_comms/behaviour_patterns.py": 0, "NoneAbsence:src/agent_comms/behaviour_patterns.py": 0, "BroadSwallow:src/agent_comms/behaviour_patterns.py": 0, "FrozenFieldWrite:src/agent_comms/child_process.py": 0, "BannedVocabulary:src/agent_comms/child_process.py": 0, "NoneAbsence:src/agent_comms/child_process.py": 0, "BroadSwallow:src/agent_comms/child_process.py": 0, "FrozenFieldWrite:src/agent_comms/commander/judge.py": 0, "BannedVocabulary:src/agent_comms/commander/judge.py": 0, "NoneAbsence:src/agent_comms/commander/judge.py": 0, "BroadSwallow:src/agent_comms/commander/judge.py": 0, "FrozenFieldWrite:src/agent_comms/commander/order.py": 0, "BannedVocabulary:src/agent_comms/commander/order.py": 0, "NoneAbsence:src/agent_comms/commander/order.py": 0, "BroadSwallow:src/agent_comms/commander/order.py": 0, "FrozenFieldWrite:src/agent_comms/commander/standing.py": 0, "BannedVocabulary:src/agent_comms/commander/standing.py": 0, "NoneAbsence:src/agent_comms/commander/standing.py": 0, "BroadSwallow:src/agent_comms/commander/standing.py": 0, "FrozenFieldWrite:src/agent_comms/connector.py": 0, "BannedVocabulary:src/agent_comms/connector.py": 0, "NoneAbsence:src/agent_comms/connector.py": 0, "BroadSwallow:src/agent_comms/connector.py": 0, "FrozenFieldWrite:src/agent_comms/goals.py": 0, "BannedVocabulary:src/agent_comms/goals.py": 0, "NoneAbsence:src/agent_comms/goals.py": 0, "BroadSwallow:src/agent_comms/goals.py": 0, "FrozenFieldWrite:src/agent_comms/todos.py": 0, "BannedVocabulary:src/agent_comms/todos.py": 0, "NoneAbsence:src/agent_comms/todos.py": 0, "BroadSwallow:src/agent_comms/todos.py": 0, "FrozenFieldWrite:src/agent_comms/tool_caller.py": 0, "BannedVocabulary:src/agent_comms/tool_caller.py": 0, "NoneAbsence:src/agent_comms/tool_caller.py": 0, "BroadSwallow:src/agent_comms/tool_caller.py": 0, "FrozenFieldWrite:src/agent_comms/tools.py": 0, "BannedVocabulary:src/agent_comms/tools.py": 0, "NoneAbsence:src/agent_comms/tools.py": 0, "BroadSwallow:src/agent_comms/tools.py": 0 }tools introduced
{}Agent-Comms-Order: 592568a1b8c3