Skip to content

P192/P197: record checked delivery in Core and refuse routine permission questions - #1955

Closed
trissim wants to merge 11 commits into
mainfrom
fix/p197-p192-on-p710
Closed

trissim wants to merge 11 commits into
mainfrom
fix/p197-p192-on-p710

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

P192/P197 takeover: rebased onto current main

Head: 1caf61d10e18bb1906b5f055fb33a834b1cfbfbb. Base: b793c7325c99c3a0f721df0ac85978daa3eb2763. Claude-code reassigned #1955 from pi-catalog to pi-toad-list in message 3022. Rebased the existing branch with an explicit old-head lease; subsequent checkpoints were ordinary pushes. This draft now targets main rather than its old P710 stack base. Not merged or installed.

Owners and coherent repairs

  • P197: OrderDelivery.verified validates and records the actual CheckPrinted in Core. CheckedDelivery owns that typed measurement. Its commit/operation members compose the existing delivery behavior through inheritance; the duplicate submission class mapping is deleted. Board, done and goal instructions derive their presentation from the checked Core delivery. A supplied print of 999 is checked again and replaced with the actual 7; each delivery runs its declared check once.
  • P192: the existing caller contract carries the destination. DirectorCaller checks the registered recipient role, and human-directed questions go through AuthorizedAct and its declaration-owned verbs. PermissionQuestion owns external question grammar, including modals and first-person subjects. No caller phrase regex, second verb roster or action-name switch. Product/paid-provider/factual/quoted questions and messages to workers retain their distinct behavior.
  • Rebase resolutions retain main's removed overload gate, non-throwing no-count measurement behavior, pinned slop catalog and exemption of claude-ai from commander rule review.
  • Retained main's pushed-origin source check: an unmerged pushed unit commit can be delivered. The old stacked parent had reintroduced an origin/main-only restriction; that regression is removed.
  • The inherited state-evidence family remains present. Its turn declaration is now the requested TurnEvidence, not an alias, so the retained combined check prints the required 7. No production data migration or alternate reader is added.

Production diff from pinned main: 346 additions / 67 deletions (net 279), including the inherited P710 changes. The P192/P197 feature allocation already declared in the original PR, Src-Budget: 162, is now present as a commit trailer. Existing inherited allocations remain. The ratchet, baseline and checker configuration are unchanged. No suppression, cast, Any, moved finding or new scanner was added.

Source evidence

Existing refactor-audit Package was used for declarations, imports, writes, branches and consumers. Before: original branch production 381 modules, tests 480, tools 35; main production 381. Those completed roots had zero parse omissions. The first 60-second source census stopped before main's test/tool roots completed; those roots are not claimed as fully enumerated. After the semantic batch: production 381 modules, zero parse omissions. The final turn-class rename changes no class count. Dynamic CLI/dataclass binding and actual C3/codec behavior were confirmed by the application/tests below, not inferred from AST alone.

Fresh actual application journey on this head

Branch source, real commander CLI, authenticated HTTP MCP server, real Comms/registry/Todo/Git/codecs; no fake Core objects, provider calls, production messages or installed-package changes.

order done worker order-P197 --sha 1caf61d10e18bb1906b5f055fb33a834b1cfbfbb --repo /home/ts/wt/pi-toad-list--P197
rc=0
worker: order order-P197 delivered as 1caf61d10e18bb1906b5f055fb33a834b1cfbfbb · Check printed 1
fresh Core reader: CheckedCommitDelivery, Check printed 1
order board: rc=0; same persisted measurement

The real check counted class CheckedCommitDelivery in the delivered source, and a scratch marker confirmed exactly one execution. The pushed feature commit was explicitly confirmed not to be an ancestor of origin/main, so this proves actual branch delivery rather than synthetic merged acceptance.

Authenticated requests to the normal connector serve entrypoint refused all three routine permission questions to a human (register, send, restart), appended no bus message, and returned HTTP 200 with isError=true and Already authorized. A product question to the human and the same send question to a worker succeeded and appended exactly two messages. The service was terminated normally after verification.

Actual uncited strike CLI refused with readable Cite the state ... --commit / --diff / --turn / --process / --runtime text and retained zero strikes.

Checks

  • Separate stack-interpreter ratchets on this exact pushed head: src/agent_comms rc=0; tools rc=0. Every head>base key: none. Both full introduced blocks follow below; all source entries are zero, tools is empty.
  • 24 focused tests passed: complete connector suite (including its actual serve/curl journey), catalog/family tests, actual check-print retention and failed-check preservation. Missing pytest-timeout plugin warning is bounded by external timeout 300 and faulthandler_timeout=60. No full-suite claim.
  • git diff --check: clean. All production edits committed/pushed. An owned standalone verification helper is retained untracked at .proof/P197-journey.py; it is not production code or a hidden repair.
  • Retained combined declaration check: 7.

Receipts under /home/ts/.cache/agent-scratch/pi-toad-list/: P197-head-src.json, P197-head-tools.json, P197-checked-final-tests.log, P197-head-application.log, P197-head-strike-refusal.log, and source-before/after reports. Owned checkout: /home/ts/wt/pi-toad-list--P197, about 23 MiB. Combined owned scratch/checkouts remain far below 3 GiB. The configured resource helper is absent; checks ran serially and bounded, using existing environments only.

Assumed / remaining state

  • Core still names pi-catalog as holder of P192/P197 under order 592568a1b8c3. The explicit reassignment authorized this source takeover; commander-only ownership/completion records have not been impersonated or changed by this worker.
  • This PR includes its previously stacked P710 evidence behavior, now rebased onto main. It is not a second independent P198 implementation.
  • Two setup runs were refused before delivery because the existing storage gate mistakes a non-Git scratch home containing P197 for an unreleased checkout. They recorded no delivery. The final continuous run used an ordinary purpose-named home; the production guard was not changed or bypassed. Reproducer and acceptance were handed to pi-worker-cpu for the related checkout-state repair; its acceptance is not claimed here.
  • No source, session, wire history, auth or UNKNOWN input from another owner was removed or replayed. The source checkout remains available for this draft review.

src/agent_comms introduced

{
  "FrozenFieldWrite:src/agent_comms/behaviour_patterns.py": 0,
  "BannedVocabulary:src/agent_comms/behaviour_patterns.py": 0,
  "NoneAbsence:src/agent_comms/behaviour_patterns.py": 0,
  "BroadSwallow:src/agent_comms/behaviour_patterns.py": 0,
  "FrozenFieldWrite:src/agent_comms/child_process.py": 0,
  "BannedVocabulary:src/agent_comms/child_process.py": 0,
  "NoneAbsence:src/agent_comms/child_process.py": 0,
  "BroadSwallow:src/agent_comms/child_process.py": 0,
  "FrozenFieldWrite:src/agent_comms/commander/judge.py": 0,
  "BannedVocabulary:src/agent_comms/commander/judge.py": 0,
  "NoneAbsence:src/agent_comms/commander/judge.py": 0,
  "BroadSwallow:src/agent_comms/commander/judge.py": 0,
  "FrozenFieldWrite:src/agent_comms/commander/order.py": 0,
  "BannedVocabulary:src/agent_comms/commander/order.py": 0,
  "NoneAbsence:src/agent_comms/commander/order.py": 0,
  "BroadSwallow:src/agent_comms/commander/order.py": 0,
  "FrozenFieldWrite:src/agent_comms/commander/standing.py": 0,
  "BannedVocabulary:src/agent_comms/commander/standing.py": 0,
  "NoneAbsence:src/agent_comms/commander/standing.py": 0,
  "BroadSwallow:src/agent_comms/commander/standing.py": 0,
  "FrozenFieldWrite:src/agent_comms/connector.py": 0,
  "BannedVocabulary:src/agent_comms/connector.py": 0,
  "NoneAbsence:src/agent_comms/connector.py": 0,
  "BroadSwallow:src/agent_comms/connector.py": 0,
  "FrozenFieldWrite:src/agent_comms/goals.py": 0,
  "BannedVocabulary:src/agent_comms/goals.py": 0,
  "NoneAbsence:src/agent_comms/goals.py": 0,
  "BroadSwallow:src/agent_comms/goals.py": 0,
  "FrozenFieldWrite:src/agent_comms/todos.py": 0,
  "BannedVocabulary:src/agent_comms/todos.py": 0,
  "NoneAbsence:src/agent_comms/todos.py": 0,
  "BroadSwallow:src/agent_comms/todos.py": 0,
  "FrozenFieldWrite:src/agent_comms/tool_caller.py": 0,
  "BannedVocabulary:src/agent_comms/tool_caller.py": 0,
  "NoneAbsence:src/agent_comms/tool_caller.py": 0,
  "BroadSwallow:src/agent_comms/tool_caller.py": 0,
  "FrozenFieldWrite:src/agent_comms/tools.py": 0,
  "BannedVocabulary:src/agent_comms/tools.py": 0,
  "NoneAbsence:src/agent_comms/tools.py": 0,
  "BroadSwallow:src/agent_comms/tools.py": 0
}

tools introduced

{}

Agent-Comms-Order: 592568a1b8c3

Copilot AI balanced review requested due to automatic review settings October 19, 2026 18:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim changed the base branch from main to fix/p710-strike-state-evidence October 19, 2026 18:36
@trissim
trissim marked this pull request as draft October 19, 2026 18:36
Checked receipt members compose existing delivery behavior and keep CheckPrinted at the verification owner. Board, goal and done output read its presentation. CommitDelivery and P710 evidence are unchanged. Working source checkpoint; final application verification follows P192.
@trissim
trissim force-pushed the fix/p197-p192-on-p710 branch from 6d5e14b to 726c94b Compare October 19, 2026 21:16
@trissim
trissim changed the base branch from fix/p710-strike-state-evidence to main October 19, 2026 21:16
Carry the destination through the existing caller contract. The director asks AuthorizedAct only for registered human recipients. Act declarations own their verbs; a shared interrogative parser tokenizes once, with no permission-phrase regex roster. Fresh review and normal directive checks remain in force.
Core rechecks a supplied false receipt and stores only the actual print. Authenticated MCP records refused routine questions without sending them, while preserving product, paid-provider, factual and quoted questions and unit messages. Actual CLI/MCP scratch-bus journey also passed.
…stion grammar

Remove the duplicate submission-type association; the checked delivery declarations already inherit the submitted type. Keep external English pronouns with the question grammar. Record the P192/P197 feature allocation already declared in draft #1955, without changing the ratchet or its baseline.

Src-Budget: 162
@trissim trissim changed the title P197/P192: record checked delivery in Core and refuse routine permission questions P192/P197: record checked delivery in Core and refuse routine permission questions Oct 19, 2026
@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing stale draft: no commit since yesterday and nobody has mentioned it on either commander's bus since midnight. Branch kept; reopen with a current owner if the work is still wanted.

@trissim trissim closed this Oct 20, 2026
@trissim
trissim deleted the fix/p197-p192-on-p710 branch October 20, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants