Repository navigation
Conversation
trissim
force-pushed
the
fix/installed-merge-closes-order
branch
from
October 19, 2026 22:41
381d760 to
0adf40e
Compare
Merged
trissim
added a commit
that referenced
this pull request
Oct 19, 2026
trissim
force-pushed
the
fix/installed-merge-closes-order
branch
from
October 19, 2026 22:56
79c6bcb to
2de6931
Compare
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1997. P266 corrects #2004 under direct commander order 3233.
Removed decisions
ProblemOrder.merged()base method.merged()is declared only onCheckedProblemOrder; reconciliation selects that capability once by type before querying PRs.MergedProgress.close()method. The existingDoneTodoState.closed()owns the row transition.Repo.contains()recognizes Git's 0/1 ancestry outcomes; other failures raise. No Git failure is caught and reclassified as False.Repeat reads use the existing record, not a cache
The canonical
MergedProblemOrderrecords the full merge SHA and retains its original checked order. Closure sets Done and clears assignment in the same revision-checked write.TodoStore.held_for_commanderselects only open, assigned rows. A subsequent observation therefore never sends that closed order back to GitHub or Git. No lru_cache, module seen-SHA dictionary, throttle, auxiliary store, or negative-result cache exists.The store makes the positive ancestry observation before taking its write lock and only commits the revision it observed. An uninstalled merge remains open; a later observation can close it after installation. Ordinary held checks and order sends retain database-only reads; the two production observation callers are board and overdue.
Verification: 381d760
11 focused checks passed, including pending/delivered originals, actual Git ancestry, exact retained original and full SHA, one-revision closure, a second read that cannot launch any subprocess, stale revision protection, checked-only selection, real Git failure propagation, board/overdue omission, and uninstalled-merge reporting.
Both unchanged ratchets ran with the existing exactly pinned audit source, borrowed read-only; that borrower has ended:
SourceLines 10 -> 70(net +60, down from +65). No other key increases;introduced_linesis empty.introduced_linesis empty.No source budget, baseline change, suppression, dependency installation or checker edit was made.
The refactor-audit Package census covers 381 production modules and 38 tools modules at the before and after commits, with zero parse omissions. Dynamic attribute receivers remain syntactically ambiguous and were read semantically; AST is not claimed as behavioral proof.
ownership.txtretains declarations and consumers.Actual two-pass overdue strace
An isolated root contains the seven unmodified retained live Todo records and identities restored stopped by Core. The actual overdue entrypoint queried actual GitHub and configured installed-checkout HEADs, then closed P202, P223, P232, P250, P253, P259 and P261 exactly once. It recorded their full SHAs; both passes printed none of those IDs. Original live orders remain open and unchanged; no native input or completion call was sent.
Command:
strace -f -e trace=execve -s 2048 -o execve.trace <shared-python> two_ticks.py.Only the watch's wait is shortened.
/usr/bin/truemarkers delimit the real ticks in the execve trace; no Comms object, progress result, ancestry answer or merge action is replaced.First pass: 7 successful Git execs. Second pass: 0 Git exec attempts, not merely zero successful calls:
P266_RETAINED_STRACE_EXIT=0; actual CLI exit 0. Startup has one package-stamp Git call before the first-pass marker. A real Core CleanHunt records the source inspection performed for this task, so unrelated due-hunt churn discovery is not due during these passes. This is not a claim that an overdue hunt's separate Git scan disappeared.Narrow reading of the order: consecutive passes mean two ticks of the same overdue process, not two fresh Python startups. Installed-merge repeat processing is measured with the unrelated hunt satisfied; no production timer or cache was added.
Delivery boundary and storage
The requested canonical
agent-comms-commander order pr P266 ...command was attempted. It correctly found the P266 checkout and refused because #2004 already exists. This existing PR body is updated through Core'spull_request_body, retaining P266's actual immutable order reference.The recorded Check of
origin/mainstill counts 1awaiting recordsite because this branch is not merged; HEAD contains zero. Nothing is merged or installed by this work. Post-install live-bus acceptance is not claimed.Owned evidence:
/home/ts/.cache/agent-scratch/pi-cn-phase3/p266/(tests.log, ratchet JSON/exits,ownership.txt,strace.log, and completeretained-two-ticks/execve.trace). Combined owned scratch/checkouts are about 371 MB, below 3 GB. The older detached P254 checkout is retained because PIDs 2374563, 2376066 and 2376067 still hold it as cwd; it must be released before removing P266 in creation order. No active process was stopped for cleanup.Assumed: configured repository checkouts are the installed checkouts; repeat passes are ticks of one watcher with an actual fresh hunt, not repeated startup or an unrelated overdue-hunt scan.
Agent-Comms-Order: 63ed167ab593