Skip to content

P291: inherit the plan phase across every problem-order state - #2056

Closed
trissim wants to merge 3 commits into
mainfrom
fix/p291-order-phase-base
Closed

trissim wants to merge 3 commits into
mainfrom
fix/p291-order-phase-base

Conversation

@trissim

@trissim trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

P291: one inherited phase field for every problem-order state

Working checkpoint 89a93c6.

Moved serves unchanged (default and wire metadata) from CheckedProblemOrder to ProblemOrder. Folded and unordered orders now inherit the actual field; PlanPhase.serving stays unguarded. No forwarding property, sibling roster or second phase classifier.

The existing destination-field transition helper now belongs to ProblemOrder too. Folding uses it, preserving the base phase and finding rather than discarding them. A new, installed-parent-compatible TodoRows carry fills the real phase of historical folded orders from their retained original, deepest first; explicit phases are not overwritten, unplanned defaults remain canonical, and repeat application makes no changes. No production old-shape reader.

Source pass: 382 production modules and 42 tool modules parsed, zero omissions. Other universal data fields moved: none. finding, pending and line already belong to ProblemOrder. id, at, owner, check/run/delivery facts belong to actual checked/held orders; similarly named Goal.order consumers are a different family and are not promoted into fabricated orders.

Mechanical check prints 0; the base declares serves and CheckedProblemOrder does not redeclare it. Long-running real live-rotate witness, source ratchet and focused tests are not yet accepted. This is a draft working checkpoint, not an installation claim.

Assumed: the field's unplanned default is meaningful for unassigned findings; folding retains its original phase as current state rather than forwarding through provenance. The merger performs environment-creating install rehearsal; this agent does not mutate original stored orders by hand.

Agent-Comms-Order: c733503a629d

Copilot AI balanced review requested due to automatic review settings October 20, 2026 01:03
@trissim
trissim marked this pull request as draft October 20, 2026 01:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2092 following the merger decision in bus5094. Do not combine this base serves-field/carry model with Folded.phase derived from retained original. Preserve the independent WithdrawnProblemOrder.require_close behavior when reconciling #2073; its implementation owner has held that PR for this work. The original P291 stored-field mechanical check is not satisfied by the selected derived-phase model and needs a commander-recorded correction. No installed acceptance is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants