Repository navigation
Preserve folded phase attribution without inheriting acceptance - #2092
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 20, 2026 02:36
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 20, 2026
Merged
trissim
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the folded-phase regression introduced in #1928. Requested by the P256 owner; contribution to P291 integration.
CheckedProblemOrder.servesremains the sole stored phase. A fold retains its original order, soFoldedProblemOrder.phasederives fromoriginal.phase, including nested folds. Folding does not inherit acceptance or the ability to assign a new checked phase. No stored-field change, carry or historical rewrite.Updated the incorrect main assertion and added one parametrized provenance test across Cutover/CommanderPage, merged/installed originals and nested folds. 17 tests passed under background timeout300. Both src and tools ratchets exit0 against26c083b39, with no introduced findings.
Candidate read of the actual retained store: P242=cutover, P245=commander_page, accepted=False for both. Their encoded-order hashes exactly match installed main: no stored phase copied or record rewritten. This candidate proof is not installation.
Source/consumer evidence uses the canonical refactor-audit Package parser; receipt under /home/ts/.cache/agent-scratch/pi-plan-claims/folded-phase-before.json. Runtime rebinding is not resolved by lexical evidence.
Do not combine #2056's copied
folded.servescarry with this derived-property repair: it would duplicate the original's phase authority. P291 integration remains with pi-connector; no edits to its branch.