Skip to content

Desktop batch 2: P738, P739, P707 - #2079

Closed
trissim wants to merge 43 commits into
mainfrom
batch/desktop-2
Closed

trissim wants to merge 43 commits into
mainfrom
batch/desktop-2

Conversation

@trissim

@trissim trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Batch on fresh main 15ba6ed:

  • PR2061 P738: order install verb reachable (InstallVerb gains OrderVerb)
  • PR2066 P739: packages rules-serve-their-reason, caution-must-pay, review-like-linus
  • PR1952 P707: carry rts orders onto Core board

Dropped: PR1918 P684 conflicts with main.

Local checks on c7a2d4e: src and tools debt ratchets introduced_lines {} (separate commands); tests/test_commander_verbs.py + tests/test_todos.py 32 passed.

Supersedes PR2063. Not merged: install-rehearsal cannot pass on desktop until P740 (install_gate.py:880 treats the running machine as laptop) lands.

🤖 Generated with Claude Code

trissim and others added 30 commits October 19, 2026 12:42
…tion fields as on main

The preflight read location.path, which FileLine never declared, so every
unordered finding failed before transfer. The creation_exclude metadata on
Todo rewrote nine field lines without changing what require_same_creation
compares; main's version stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ard_order to the line limit

tests/test_rts_open_carry.py imported cutover.issue_rts_orders, which this
branch deletes in favor of tools/carry_rts_orders.py. CheckedProblemOrder's
bare pending annotation restated ProblemOrder's declared default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…one staged commit for the carry

The board's order columns come from a typed BoardOrder row, and the finding's
place (not its instructions) fills the Owner file column. clock() is the one
HH:MM formatter, used by orders, install deadlines and order.py's hhmm. The carry
decodes hunts through the Hunt family, writes every row through TodoStore on a
staged copy, checks the RTS sources, then commits once by SQLite backup. Missing
finding checkouts and orders without Banned lines are refused by problem id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the order

The import script decodes each RTS file once (FieldCodec dataclasses, two boundary
decoders for the null spellings) instead of reading dict keys everywhere. The board
row's cells are one method on the order family, so BoardOrder is gone. Deleted the
unused Todo.require_released_order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete the check-directory fallback. Print the problem and order identity before repository resolution; original Git failures propagate without a catch or default.
Copilot AI balanced review requested due to automatic review settings October 20, 2026 01:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

install_gate result from the gaming merger, for head c7a2d4e.

  • Command: tools/install_gate.py --pr 2079 --scratch /tmp/claude-1000/-home-ts-code-projects-openhcs/696126c1-8112-4b77-8879-c1f14ea961ce/scratchpad/gate2079, run after batch 41 (16ecfb5) was installed here. Result: rc=1.
  • Both machines failed with the same error, "Insufficient room for snapshot and rehearsal": laptop (gaming, 919M bus) and desktop. The gate needs free space of 2× the bus plus storage_floor() (install_gate.py:246, :325). This machine has /home 6.4G free and the scratch tmpfs 2.2G free. The desktop entry also needs room for its 24G bus here.
  • Report: /tmp/claude-1000/-home-ts-code-projects-openhcs/696126c1-8112-4b77-8879-c1f14ea961ce/scratchpad/gate2079/report-c7a2d4e9b9b7-793421.json (on the gaming machine).
  • No rehearsal ran, so this is not a pass. I did not merge anything.

🤖 Generated with Claude Code

@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2100, which contains #2061, #2066 and #1952 on current main.

@trissim trissim closed this Oct 20, 2026
@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

merger: install_gate at head c7a2d4e with HDD scratch: rc=124 at 23:12:22 (1800s timeout). Rehearsal exited with code 1: 'Installer failed without a declared refusal; private traceback retained on host', then unfinished (signal 15). Report: /home/ts/mount/hdd/merger-gate-scratch/gate2079/report-c7a2d4e9b9b7-1058207.json on ts-gaming. Not merged.

@trissim
trissim deleted the batch/desktop-2 branch October 20, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants