Repository navigation
Conversation
trissim
marked this pull request as ready for review
October 20, 2026 03:46
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Author
|
Landed on main through batch #2133. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native soft-order refusal
Fixes the concrete row-10 mismatch from P298 without adding or changing a word list.
OrderTextalready rejects the three texts; native order entry never invoked the declaredDirectiveTextfamily that includes it.PendingProblemOrder.require_wordingchecks edit, prohibition, report and application-run prose through the existing family. Shell commands and source paths remain data.Actual retained-state proof
Ran the real pushed P298
OrderWordingComparison.compare_messagesagainst native source on this branch and the configured retained commander state. All three exact originals supplied by pi-toad-viewport (5071/46f9c545f560, 5069/d3136ab86138, 5050/3a6fbd6a619e) now producecurrent_refusals=3, native_refusals=3, mismatches=0, passed=true. The independently pinned 5084/79cf1033ccda case also passes with both refusals=1. Follow-up paired proof explicitly assertspassed=True,current_refusals=1,native_refusals=1andmismatches=0, without selecting expectations from the result. It uses the frozen P298 checker blob from63c189aa2(blob5c7e1ea6a59e9088e3ca87faeb856e951e5c92f8) because the peer reused its checkout; no peer checkout or assertion was changed. Receipt:native-soft-pinned-checker.log, exit0. These calls reach actualProblemOrderGoalAction.request_refbefore reservation; no order publication or provider call. Private message bodies are not copied into the PR.Final head:
923c12eb6a990745c8a0e6a0de7fd9884f0c987a. First implementation pushed at23:38:05, within10 minutes; PR opened23:39:44, within20 minutes.At this final head, the ordinary ambient
OrderWordingComparison.read()also PASSES:5 currently retained texts, current_refusals=5, native_refusals=5, mismatches=0. This is in addition to the three exact supplied originals and the pinned fourth case, not a substitution for them.Final local checks, existing shared Python, background/timeout300/faulthandler:
ef4cc72dasource control prints its loaded module path and gives 3 passed,2 failed for exactly these5 cases. The remaining failures aretest_a_withdrawn_order_is_neither_open_nor_overdue_and_strikes_no_oneandtest_commander_reads_decode_only_open_todos. Sent the reproducer and owner request to claude-code; no unrelated closure/index patch.tools/debt_ratchet.py --root src --base origin/main --head HEAD:exit0, no positive deltas or introduced nonzero findings.--root toolscommand:exit0, no positive deltas or introduced findings.git diff --check:clean. No production install, settings publication, restart or provider call.The prescribed resource-check launcher is missing; manual measurement before these bounded checks showed13GiB disk free and3.7GiB available RAM. No environment, worktree or full bus copy was created.
Ownership evidence
Before and after censuses use existing audit
Package/Repository:396 src modules,47 tools,509 tests at each head; zero parse omissions. It enumerates declarations, imports, assignments, calls and decisions around OrderWords, OrderText, DirectiveText, OrderFile, ProblemOrderGoalAction, PendingProblemOrder and AssignTodo. Read the native entry, both reserve implementations, TodoStore.create/assign, AssignTodo.apply and current OrderFile.problems_found. Actual searchrg -n -F 'could you|would you|can you' srcreturns onlytodos.py:1067, the existingOrderText.REFUSED. The sole soft-word regex remains OrderText. No new regex, alias, codec, historical reader or policy roster. Dynamic Python receiver resolution is not proven by AST; actual native calls confirm it.Receipts:
/home/ts/.cache/agent-scratch/pi-install-gate/native-soft-*. Merger still owes installation and installed readback. P298's owner retains its comparison/test changes; this branch does not weaken its known-defect assertions.Assumed: fresh direct request5324 authorizes this separate repair while P296 remains held; no new problem ID was supplied.