Skip to content

P233: give the Claude transport fixture its owned subscription - #2125

Closed
trissim wants to merge 1 commit into
mainfrom
fix/p233-transport-fixture
Closed

trissim wants to merge 1 commit into
mainfrom
fix/p233-transport-fixture

Conversation

@trissim

@trissim trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

P233 follow-up — align the retained transport acceptance fixture

Reported by pi-cn-phase7 and pi-cmd-tools (5616), after the session-owned bridge merged in #1950. P233 is already recorded done with no holder; this is a test-only follow-up, not a new active order or a P305 transport change.

The fixture directly invokes ClaudeBridge.publish_transcript() but constructed the bridge with Watch(). For a LineMonitorBridge, Watch attaches a Monitor reader; it does not own a transcript subscription. Serve owns the explicit transcript path.

  • Construct the producer with Serve(owner=ProcessIdentity.capture(os.getpid()), transcript=path).
  • Explicitly assert that Watch().transcript_source() still raises the existing refusal.
  • Keep the actual file publication, external transcript store, CLI/tool query and complete turn/call/result assertions unchanged.
  • No production code or subscription guard changes.

Head: 5039de2, based on main ef4cc72.

Background verification under timeout 300, PYTHONPATH=src and shared Python with -X faulthandler:

tests/test_turn_digests.py tests/test_session_bridge.py
9 passed, 1 warning in 18.49s

The existing warning is the unknown pytest timeout configuration option. The previously failing acceptance now exercises real file publication through the private bus and the actual CLI/tool endpoint; no provider request is needed.

Separate tools/src ratchet outputs are retained at /home/ts/.cache/agent-scratch/pi-bridge-compact/P233/transport-followup-{tools,src}.log. The production trees are byte-identical to the pinned base.

Diff: 1 file, +6/-2. Original regression receipt: /home/ts/.cache/agent-scratch/pi-cn-phase7/P302-main-transport-baseline.log. Passing receipt: P233/transport-followup-tests.log under the owned scratch root.

Assumed: merger owns integration; this fixture repair neither changes nor claims P281's automatic hook publication.

Separate ratchets: tools 0; src 0, positive deltas {}, introduced findings {}.

Agent-Comms-Order: 4da91cc38c5d

Copilot AI balanced review requested due to automatic review settings October 20, 2026 04:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Landed on main through batch #2133.

@trissim trissim closed this Oct 20, 2026
trissim added a commit that referenced this pull request Oct 20, 2026
Batch mD-1: P233 fixture, native order wording (#2125 #2117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants