Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Author
|
Landed on main through batch #2133. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P233 follow-up — align the retained transport acceptance fixture
Reported by pi-cn-phase7 and pi-cmd-tools (5616), after the session-owned bridge merged in #1950. P233 is already recorded done with no holder; this is a test-only follow-up, not a new active order or a P305 transport change.
The fixture directly invokes
ClaudeBridge.publish_transcript()but constructed the bridge withWatch(). For a LineMonitorBridge, Watch attaches a Monitor reader; it does not own a transcript subscription. Serve owns the explicit transcript path.Serve(owner=ProcessIdentity.capture(os.getpid()), transcript=path).Watch().transcript_source()still raises the existing refusal.Head: 5039de2, based on main ef4cc72.
Background verification under timeout 300, PYTHONPATH=src and shared Python with -X faulthandler:
The existing warning is the unknown pytest timeout configuration option. The previously failing acceptance now exercises real file publication through the private bus and the actual CLI/tool endpoint; no provider request is needed.
Separate tools/src ratchet outputs are retained at
/home/ts/.cache/agent-scratch/pi-bridge-compact/P233/transport-followup-{tools,src}.log. The production trees are byte-identical to the pinned base.Diff: 1 file, +6/-2. Original regression receipt:
/home/ts/.cache/agent-scratch/pi-cn-phase7/P302-main-transport-baseline.log. Passing receipt:P233/transport-followup-tests.logunder the owned scratch root.Assumed: merger owns integration; this fixture repair neither changes nor claims P281's automatic hook publication.
Separate ratchets: tools 0; src 0, positive deltas
{}, introduced findings{}.Agent-Comms-Order: 4da91cc38c5d