Repository navigation
Restore Toad message bodies with one incoming envelope constructor - #2879
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 19:15
trissim
enabled auto-merge
October 23, 2026 19:15
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 94f41e3, every finding: |
The envelope move dropped the only assertion that constructing an IncomingTranscript from a record raises TypeError, leaving the guard at transcript_events.py:256 untested. Restore it beside the .of assertions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live fix, Part A only: stored records reached IncomingTranscript and every wire view failed. Message now owns the envelope property; IncomingTranscript.of is the single conversion point. BusRecord inherits it, its guard remains, and both Core callers use of without converting at the call site. Toad counterpart: OpenHCSDev/toad#1160. Reattachment stays separate in #2860 / toad#1159.
Core head ccea4d9; pushed head matches ls-remote. Ready and auto-merge enabled after the focused test run passed.
Validation:
Qualification used compiled Core ccea4d9 and the separately built Toad Part A wheel, with the installed/declared ui-theme 60a324455552a6feeb3868c41551948a58bdcc67. Newly fetched ui-theme bb373820 removes member.variable and breaks unchanged Toad at textual_colours.py:328 before the view opens. No production dependency pin is changed by this PR.
Evidence: /home/ts/.cache/agent-scratch/route-readers-2860/{partA-tests.log,read-stall-comms-A.log,read-stall-test-A.log}. Original sessions/auth/uncertain inputs are preserved. Assumed: paired Core/Toad release; application acceptance targets the installed dependency set, not the unrelated newly broken theme API. No runtime guard is weakened.