Repository navigation
Render stored wire messages through IncomingTranscript.of - #1160
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 19:18
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
wire_history.py calls IncomingTranscript.of, which first exists on agent-comms main at db3b35509 (#2879). The lock pinned 70174680, so an install from this head would raise AttributeError on every wire read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The only conflict was the agent-comms pin: main held 38840b0f, an ancestor of db3b35509, the #2879 merge this branch needs. Keep db3b35509. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part A only: restore message bodies now, separate from runtime reattachment (#1159). Core counterpart: OpenHCSDev/agent-comms#2879 at ccea4d9a0a3a30d86b1d2204d4165badde33e915.
Both WireFragment and MessageFragment call IncomingTranscript.of; MessageRow keeps its stored record. Unexpected source errors reach source_failed, which retires the source before showing its existing error, so completion cannot restore a live state and retry forever. The private-record guard stays intact.
Head 1965a43 matches ls-remote.
Validation:
The old retry path restores operation.source at transcript_source_preparation.py:385 even when work raises outside WorkingTranscript.execute's former OSError/ValueError catch; the generic worker failure is consumed by app.py:259-265 instead of the pager's source_failed. The new error boundary is transcript_state.py:405-407, and source_failed retires at transcript_source_preparation.py:132 before reporting at :133-134.
The newly fetched ui-theme bb373820 is incompatible with unchanged Toad (ForegroundColour.variable missing). Qualification uses the installed/declared ui-theme 60a324455552a6feeb3868c41551948a58bdcc67, not a production pin change. The larger optional test set also exposed untouched tests still calling Registration.new_thread; those unrelated baseline tests were not reported as passing.
Evidence: /home/ts/.cache/agent-scratch/route-readers-2860/{partA-tests.log,partA-toad-end.log,read-stall-comms-A.log,read-stall-test-A.log}. Assumed: paired Core/Toad release and the installed dependency set. No live root, sessions or uncertain inputs are changed; no read-error fallback or constructor exception workaround is introduced.