Repository navigation
Trust decoded IDs across queued and tracked native inputs - #2936
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 22:06
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP and selected-native IDs were decoded again after ingress. Delete only the three plain-function repeats whose source and test callers already supply validated IDs. Keep both constructor checks and the native reader with raw test callers. BOUND-1: identity spelling is checked at entry, rather than re-established at internal hops.
Six-site result
All paths below are relative to src/agent_comms unless prefixed tests/. Line numbers identify the incoming source at 83bf48f; removed lines retain their old location for review.
Caller inventory
Grepped all six entry points, their request/queue subclasses and forwarding callers across src, tests and tools before editing. Used the existing refactor-audit Package.load AST reader to inspect declarations, imports/aliases and call expressions: 454 source modules, 488 test modules and 10 tools modules parsed, zero omissions. This source inventory does not resolve arbitrary external callers or runtime rebinding.
Queued-input tests reviewed: native_backend_fixture.py:134; test_current_input_origin.py:123/128/185/190/215/264; test_owned_turn_goal_replacement.py:67/86; test_retained_context_operations.py:142; test_stack_native_compaction.py:322; test_stack_persistent_compaction.py:227/232/300. Every one omits input_id. Prompt constructors reviewed in test_acp_extension.py:136/137, test_acp_queue_contract.py:52/74/113 and test_current_input_origin.py:82 likewise use the declared mint default. External acp.schema.PromptRequest calls were distinguished by their imports, not confused with this Core family.
Final change
Only native_pi.py, queued_input.py and tracked_turn.py differ. No helper, wrapper, replacement guard, assert or exception handler added. No tests or files owned by #2914/#2934/#2933/#2935/#2927 changed. Tests were not run, per order.
Assumed: declared request decoding and the retained PromptRequest constructor own incoming IDs; None means mint a new queued ID; stored PromptBinding keys retain their declared SQL constraints; only the inspected repository callers are covered. No live runtime or store was changed.