Skip to content

Trust decoded IDs across queued and tracked native inputs #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 23, 2026
Merged

Trust decoded IDs across queued and tracked native inputs #2936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efcd93
Trust boundary-decoded IDs through queued and tracked inputs
trissim Oct 23, 2026
b3e2735
Keep constructor validation on FieldCodec-decoded requests
trissim Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/agent_comms/native_pi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,6 @@ def read_tracked_input_commitment(

An unreadable or malformed journal is not an uncommitted input and raises.
"""
Id128Text.decode(input_id)
session_file = Path(session_file).absolute()
from .native_entries import NativeEvidenceRead

Expand Down
2 changes: 1 addition & 1 deletion src/agent_comms/queued_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def capture(
text or prompt or "[image prompt]",
echo,
context,
Id128Text.mint() if input_id is None else Id128Text.decode(input_id),
Id128Text.mint() if input_id is None else input_id,
prompt,
images,
controller,
Expand Down
3 changes: 1 addition & 2 deletions src/agent_comms/tracked_turn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from .backend import InputStartListener, TurnSession
from .coordinator import Coordination
from .errors import RelationViolationError
from .field_codec import Id128Text, MalformedRecord
from .field_codec import MalformedRecord
from .external_transcript import DraftRow
from .following_inputs import FollowingInputs
from .maintenance_barrier import UNCOORDINATED_INGRESS, MaintenanceIngress
Expand Down Expand Up @@ -290,7 +290,6 @@ async def execute(
execution: NativeExecution,
following: FollowingInputs = NO_FOLLOWING_INPUTS,
) -> NativeTurnResult:
Id128Text.decode(input_id)
if not prompt or not isinstance(prompt, str):
raise ValueError("A native turn requires a nonempty prompt")
measurements = startup.measurements
Expand Down
Loading