Repository navigation
B6d: B6's remaining functional fixes, without the formatting - #1221
Merged
Merged
Conversation
…ly edits or ratchet mixin moves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-function catalog policy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # tests/unit/test_named_checkpoint_publication.py
…ame; handoff Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… docs changes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Passthrough helpers sit on the group scope and reuse the manifest's path-aligned record lookup; the four unused main-window theme methods are deleted and guarded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The theme-method deletion took the @singledispatchmethod line with it, so the class body failed at the first .register. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
U4 moved the connection spec to formbridge, where transport_endpoint takes the config; the smoke still called it without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes from B6 (#1195) that main still needs, without its formatting. #1212 took B6's E1 boundary fix and #1214 its CI trigger restructuring; this is the rest. Receipt:
docs/refactor/consolidation-20261009/B6d-remaining-fixes.md.Fixes
"Fails on main" means: this branch's test file run against main's production code (
ae6ddace5) fails, and passes here.test_capabilities.py::test_requestless_ui_bridge_capability_passes_connection_as_connectiontest_execution_control_stop_during_compile.py(2 cases)test_function_outputs.py::test_metadata_document_targets_follow_backend_declaration[omero_local]REQUIRED_DISTRIBUTIONS)openhcs-basicpy, but the catalog imported its moduletest_library_registry_discovery.py(7 cases)os.cpu_count()where there is no affinity APItest_preparation_admission.py::test_platform_without_affinity_admits_its_online_cpussitetest_aggregate_source_scope.py::test_axis_varying_between_runtime_planes_is_kept_not_reducedMatchImageStackLabelstest_singleton_rgb_label_invocation_477.py[SliceAlignedLabels]dataclasses.replacefroze unset fields; a results path was forcedtest_openhcs_adapter.py::test_openhcs_adapter_preserves_declared_main_flow_output_policytest_build_mcp_knowledge_assets.py(import error on main)transport_endpoint()called without its configtest_smoke_installed_gui.py(import error on main); the GUI step ofsmoke_local.shNo local test separates these from main; the reason is given:
ImagePayload.of.metadatawas read off plain arraysViewerType.valuebegin_runmahotasis a core dependencypartition_valueswells'L'uint32; custom-function sources are written as bytes; Ctrl+Break stops the CLI; dataset writability is probed by creating a file;.gitattributeskeeps committed bytes; test process reaping skips process groupsQApplicationfirst; sibling test modules import throughtests; a 3.11-invalid f-stringTwo slips in the interrupted work, fixed here: the theme-method deletion had also removed
@singledispatchmethodfromOpenHCSMainWindow.on_session_event(the class body failed at the first.register), and one test still named the pre-K1RuntimePlaneAxis.SOURCE_BINDING.Dropped as formatting-only or out of scope
cf0b8eb8c,f2ae23c97,2ed28bb32,ae618be9d,7f5710ae9,3e089a3f2) and every hunk that only re-wrapped lines.239953c4c,ab03ba7ba,24bfafede).docs/source,docs/audits,README.mdandvalidate_docs.pychanges (audit re-pins).Ratchet
OpenHCSMainWindowandPatternGroupExecutionRequestare at their size budget (keeping the window's theme methods givesGodClassExcess +4). The four theme methods had no caller and are deleted (unused, guarded intest_dead_ui_code_guards.py); the passthrough helpers sit onPatternGroupExecutionScope.Verification (head
cccda278e, base6c1312d36)595 passed.smoke_local.shwith the GUI step:smoke rc=0(7 passed; GUI exit 0).guardrails_local.sh:guardrails rc=0(three ratchets exit 0, 38 passed, nra-r1"increased": []).1 passed(the test asserts all 30 cases), run with a privateHOMEso its sockets were not shared. Two earlier runs on the shared socket directory gave 28/30: in each, two cases compiled on a server started from another checkout (the error named that checkout's path), which is the fault B7: an execution client reaches only a server it may use #1211 fixes.-n 2: 36 passed, 3 failed, 1 skipped; two of the three pass serially. The third,test_measured_repetitions_share_one_owned_ordinary_server, failed 3 of 7 runs with "endpoint was already in use" while other agents' servers were running; same fault.Not verified locally: Windows and macOS paths, the installed demo, the wheel smoke, the real-viewer official30 variants (their test was updated to the viewer families and collects, 92 tests; not run).
B6d · PR #1221 · guards 4/4 · production −256 +524 · tests −263 +877
🤖 Generated with Claude Code