Repository navigation
Project grouped viewer selection onto current native slices (#548) - #549
Conversation
|
Source-qualified checkpoint f1b9607 (production143f3f033). Original Qt controls04 terminal0: 24 PASS in4.38s, peak355647488B/MemoryMax536870912/Swap0/OOM0. Log /home/ts/wt/openhcs-issue-batch-20260929/engineering548-source04.log. Native fixture first reproduces Shapes multi-offslice selected_data zero-size minimum error, then verifies original owner correction without changing logical subject membership, geometry or IDs. Mixed Points/Shapes and source-plane navigation retain requested row; original conflict/invalid selection checks pass. Actual import origins printed: source owner from this isolated checkout, baseline peers from target08 and paired installed dependencies; arraybridge/zmqruntime are paired installed paths. This is source-owner control against pinned peers, NOT an ordinary new installed package or public MCP acceptance. Target08 immutable, no dependency/arraybridge source edits. PTY83828 terminal0; scope5410732e4d224b709ec69f9062f9ae29 closed. Earlier distinct01 import failure (foreign source zmqruntime lacks AckReturnRoute),02 pytest plugin duplicate,03 22PASS/2 test-consumer failures remain in original tool journals. Async fixture now waits for actual queued navigation; unrelated-selection rejection moved to its one original exact-set authority. No product fallback/assertion weakening. Singer owns adapting #522 preserve_selection restore to this same original displayed projection; no copied procedure. Next remaining acceptance is ordinary packaged/public synthetic receiving after parent resource/custody release, not frozen P001 replay. Borrowed546 operations remain untouched. |
|
Ordinary receiving package prepared separately after the accepted f1b source checkpoint: engineering548/public88-attempt01/READY.json + program.json + RECEIVING.rst + PUBLIC.commands. Original wheel verifier PASS815 tracked source,90 declared assets,13 complete skill members and2 native binaries; actual installed build_server constructs104tools. Selection module source/wheel/target SHA2ad71c27948120f1b1cb7a18f57a749b26fec210ac748fba8fba2ff95612414a. All preparation scopes terminal/absent; sole actual wheel build peak286167040B under512Mi/Swap0. Original fixed546 successor preparation keeps every existing run reference, adds only ADMIN_54988; no original installed target08 or scientist/dependency mutation. Public synthetic case uses original writer-generated subject7 members on Z0/Z1 plus unrelated8, full source/calibration roundtrip; original authoring fixture failures retained. Public MCP and native captures remain NOT LAUNCHED, awaiting parent frozen publication/fresh original guard for existing display88/viewer6020, no native/catalog/science job or Root394 prerequisite. |
|
Actual installed public MCP receiving is complete on the separately qualified ordinary f1b package (merged61f). Source-bearing saved Shapes fixture: subject7 row0 on Z0 selects source [0,1] and off-slice Z1 []; navigating row0 on Z1 first establishes frame1/worldZ2, selects [0,1], leaves Z0 []; unrelated subject8 row2 selects only [2]. No zero-size reduction and no lost requested row. All3 layers remain mounted; geometry/source identities/calibration intact. All9 original raw/result/combined native PNGs personally opened; exact matched camera/axes/dimensions/visibility and hashes preserved. Public close acknowledged exact viewer2062055/create1791061587.43, process_exited and endpoint_terminated true. Original shell75939 terminal0; MCP/viewer/recorder absent, ports6020/7020 absent, scopeinactive. Peak1.108GB within3Gi/Swap0. All34 frozen packet hashes still PASS. Receipt: /home/ts/wt/openhcs-issue-batch-20260929/engineering548/public88-attempt01/ADMIN_54988/author-workspace/output/PUBLIC-RECEIVING.rst; ledger and PUBLIC-ACTUAL-FREEZE.sha256 adjacent. Original pre-MCP WM refusal retained, distinct direct dev_client journals preserved. This is actual shared Shapes selection acceptance, not replay of scientific graph row119 or biological success. |
Working original-owner checkpoint for #548. Singer released _synchronize_linked_group/select_indices/_apply_selection-related selection hooks from #522; #541 analysis units and Root #394 graph writer/codec remain untouched. No frozen target08 or borrowed546 operations changes.
Canonical logical subject membership stays on existing NapariResultSelectionGroupAuthority/index. Native selected_data is its current-slice projection from the original Napari _indices_view, not a new store or per-kind renderer roster. The requested source row must have displayed geometry before linked native assignments. UI singleton selection navigates through existing geometry/source-frame code before expanding linked members. Removed premature expansion and failure-finally resubmission; exact native assignments/readback use the original selection authority.
Source mechanism: native Shapes.selected_data calls interaction_box. A multimember selection with no displayed vertices reaches create_box(empty) and min(). Existing controller previously assigned all logical members across linked layers irrespective of slice. Frozen row119 shares this error signature, but its log has no traceback or complete linked membership; the exact original reduction site is not claimed proven.
Scoped AST declaration/call/write inventory covered runtime + ROI manager family; production/data type dependencies read semantically. No Python parse omissions in that scoped inventory; not a whole repository/NRA proof. Relevant IMPL-12/IDEN-5: keep one native selection writer and existing logical group owner. Proportionate real Qt synthetic controls follow coherent source; installed MCP receiving remains a separate parent-owned step. No native/server/provider/replay, no ancestry from private Root.
Closes #548