Skip to content

Fix shared native axis layout and visible footer ownership (#551) - #554

Merged
trissim merged 8 commits into
mainfrom
fix/semantic-viewer-frame-551
Oct 4, 2026
Merged

trissim merged 8 commits into
mainfrom
fix/semantic-viewer-frame-551

Conversation

@trissim

@trissim trissim commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Repair shared native frames and visible-route labels (#551)

Current head ff1d1ad integrates main ed58ea5 normally. Ordinary package04 pins
2dab1c7; both viewer modules and both control files are byte-unchanged after
integration. This is not a whole-current-main package claim. Target08, all SCI,
foreign dirty gitlinks and borrowed546 operations remain untouched.

An earlier five-axis manual raw route was right-aligned against a later seven-axis
result, mapping timepoint onto well. Hidden result routes could also supply the
wrong channel/well footer. This does not establish analytical source-pixel swapping.

One existing owner and migration closure

  • ViewerComponentLayout remains the sole slot union. NapariLayerRouteStateStore
    derives layout/domain from original mounted declarations, including previously
    LAYER-valued channel/well; the original tracker retains coordinate ordering.
  • The original reconciliation traversal preflights the complete batch before
    incoming mount. Its typed rematerialization request prevents nested traversal;
    no recursion flag, second axis store, renderer roster or codec was introduced.
  • One transient native Dims snapshot carries point/order/range through semantic
    slot insertion. NapariAxisPresentation maps source calibration and singleton
    offsets before native Dims clips points. Live bounds remain layer-derived.
  • Cooperative original handler MI preserves image presentation and source-member
    selection. Singer explicitly released the complete 522 retention family; no
    Root ancestry, navigation rewrite or second selection authority was received.
  • Only mounted visible routes supply footer labels. Original missing-domain,
    fractional/source, selection and unsafe same-layout expansion guards remain.

Verified checkpoint

30 installed real-Napari/Qt model controls PASS in7.09s, peak485957632B/Swap0/OOM0:
both loading orders; four earlier5D raw routes; A01/D06(global41) and two channels;
Points/Shapes and replacement modes; source-member selection, intensity, raw pixel
signatures and footer identity. Explicit D06/channel2 focus survives promotion
immediately, not inferred after manual navigation. Unsafe extent expansion rejects.

Ordinary wheel/target equality:815 tracked files,90 declared knowledge/skill assets,
all13 skill members,2 native binaries. Actual installed MCP construction104 tools.
No public native/catalog/provider launched. Named AST census704 production+112
actual dependency modules,166 sites/no omissions at f25; final frame corrections
stay within that owner. AST is source evidence, not equivalence proof.

Exact retained receipts under /home/ts/wt/openhcs-issue-batch-20260929/engineering551:
controls07.log, proof04.log, construction04.log, FAMILY-AFTER-f25.json,
public88-attempt01/READY-PACKAGE04.json. All earlier negatives remain unchanged.
The original synthetic generator emitted192 tiny16x16 planes declaring96 wells;
original typed writer emitted4 source-bearing ROI ZIPs. No biological/golden data.

Public native acceptance is now complete on immutable package04: original
dev_client/MCP to owned viewer, both loading orders, all four numeric/state/source/
selection witnesses, and six personally reopened raw/result/combined PNGs.
Each triplet preserves its camera/native point/axes and matching source transforms.
Both combined images show the blue selected polygon AND the white raw glyph.
They are deliberately at different synthetic source YX coordinates, not an overlay
accuracy claim. Actual selected-file well domain is A01/D06, hence D06 native1;
the earlier recipe's entire96-well/global41 assertion is NOT publicly qualified.
The installed model controls retain their separate full-domain test strength.

An earlier visual reading incorrectly reported combined-invisible. Its original
PUBLIC-FAILED01.rst is preserved; PUBLIC-CORRECTION02.rst explicitly retracts that
claim and CAPTURE-LEDGER02.json identifies all six original images/native readbacks.
A separately journalled bounded visibility sequence reproduces the original
combined SHA d54decd7b676df2a86756b4e8bfb46bf0e79e66ad24df867cc72499fc8f40ad7;
both features are visible. No renderer/blending/delay/source patch was warranted.
Parent independently verified original combined ROI pixel RGB39,70,178 and
raw glyph RGB255,255,255; result-only glyph is black.

All three exact owned viewers have positive public ACK/process-exit/endpoint
termination, both client journals terminal0;6013/7013 are absent and scopes inactive.
Latest diagnostic peak974409728B/Swap0. Existing X94/SCI helpers remain untouched.
Evidence: engineering551/public94-attempt01/{PUBLIC-CORRECTION02.rst,
CAPTURE-LEDGER02.json} and original ADMIN_55494/author-workspace/output/{runtime,qa}.
Current main's two viewer hunks concern spacing-owner delegation and spacing export,
not this shared-slot/footer reconciliation. No Root ancestry is merged via this PR.
#549 has its own completed and closed receiving evidence, not substituted here.

Refs #551; does not claim Root394 producer/publication or biological acceptance.

Closes #551

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit f2066de into main Oct 4, 2026
5 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native mixed-route QA shows stale channel/well labels and omits raw in combined views

2 participants