Skip to content

Mark scroll views and scrollbars as independent of height and style - #92

Merged
trissim merged 3 commits into
mainfrom
perf/stored-extent-measurement-20261007
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
perf/stored-extent-measurement-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

A new StoredVirtualSize dependency in _measurement.py says a scroll view's content size depends only on its stored virtual_size, unless a subclass replaces that attribute. ScrollView.get_content_width and get_content_height are tagged with it. ScrollBar gets a _render_styles_sensitive method, so changes to scrollbar colors repaint without invalidating measurements. One test file is updated.

@trissim
trissim marked this pull request as ready for review October 7, 2026 08:39
Copilot AI balanced review requested due to automatic review settings October 7, 2026 08:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 480f824 into main Oct 7, 2026
2 of 22 checks passed
@trissim trissim changed the title Preserve native line measurements across ancestor paint changes Mark scroll views and scrollbars as independent of height and style Oct 11, 2026
@trissim
trissim deleted the perf/stored-extent-measurement-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants