Skip to content

Mark scroll views and scrollbars as independent of height and style #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 3 commits into from
Oct 7, 2026
Merged

Mark scroll views and scrollbars as independent of height and style #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3874a7
Declare native line extent and scrollbar paint measurement inputs
trissim Oct 7, 2026
8e1547f
Keep custom and live-replaced chrome measurements conservative
trissim Oct 7, 2026
2f64f51
Publish scoped native measurement and final loaded App qualification
trissim Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions evidence/stored-extent-measurement-20261007/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Native line-surface measurement inputs

ScrollView measures its authored virtual_size, whose original Reactive writes
already request layout. Its two methods now declare that source through the
existing HeightDependency family. Computed or replaced virtual_size access and
undeclared method overrides remain context-sensitive.

Original ScrollBarRender changes colors without changing cell extent. ScrollBar
and its Blank corner now supply that fact through the existing renderer hook.
The live instance renderer is checked; custom renderers/wrappers stay opaque.
This completes the virtual-child supply which made the earlier ScrollView-only
candidate ineffective. No descendant traversal, style epoch, placement update,
refresh callback, size mutation or arrangement fence is bypassed.

Four distinct affected checks passed: mounted Log/TextArea paint preservation
and extent retirement; native container-only resize; computed/replaced extent
and undeclared width/height methods; custom scrollbar classes and live method
replacement. The two first authored failures incorrectly treated RichLog as
having the same width declaration as ScrollView and then checked only its
height policy. Its genuine width override stays conservative; raw failures
remain in checks-first.log and checks.log. No producer was broadened to pass.

The final existing source Toad App completed at production 8e1547f62 with ten
tabs, 508 widgets, zero inputs/providers and empty stderr. Actual pointer
sidebar first-display medians were 33.5/34.8 ms (maxima 100.9/65.0 ms).
app.json records original cProfile call/duration measurements and profile
hashes; raw output is retained here. This is headless completed display, not
terminal pixels, an agent-switch comparison or an installed latency claim.
The earlier prototype App remains at
/home/ts/.cache/agent-scratch/native-line-measurement-app-20261007; final source
App profiles remain at native-line-measurement-app02-20261007 in the same
scratch parent. The final guard correction narrowed custom class/instance
supply; it did not alter native rendered dimensions or style publication.

The original recursive traversal and every true geometry mutation remain.
Subclasses of ScrollBar/Corner stay conservative because extra descriptors can
independently alter shape. Base instances also check live bound methods and
renderer selection; no per-event result is retained. Original reactive access
supply distinguishes computed from stored extent without duplicating discovery.
AST parses 724 native production/test modules with zero omissions, covering
all dependency, source-access, renderer and invalidation consumers.

No package/public operation or reliable overall speed claim. The actual agent
mount delay and expensive arrangements remain unresolved; this change retires
an unnecessary native measurement dependency rather than suppressing layouts.
Empty file added evidence/stored-extent-measurement-20261007/app-stderr.log
View file
Open in desktop
Empty file.
315 changes: 315 additions & 0 deletions evidence/stored-extent-measurement-20261007/app-stdout.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,315 @@
{
"boundary": "completed headless _display; not terminal pixels",
"tabs": 10,
"pointer": true,
"active_widgets": 508,
"toggle_first_paint": {
"#channels-sidebar": {
"median_ms": 33.5,
"p95_ms": 37.9,
"max_ms": 100.9
},
"#thread-sidebar": {
"median_ms": 34.8,
"p95_ms": 40.9,
"max_ms": 65.0
}
}
}
{
"publication_trace": [
{
"elapsed_ms": 28.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": [
[
4,
9,
109,
25
],
[
4,
10,
109,
1
]
]
},
{
"elapsed_ms": 100.7,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 31.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 32.8,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 33.0,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 35.3,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 37.9,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 32.3,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 33.9,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 37.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 31.1,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": false,
"right_region": [
80,
3,
40,
38
],
"exclusions": []
},
{
"elapsed_ms": 64.8,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 40.5,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": false,
"right_region": [
80,
3,
40,
38
],
"exclusions": []
},
{
"elapsed_ms": 24.9,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 38.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": false,
"right_region": [
80,
3,
40,
38
],
"exclusions": []
},
{
"elapsed_ms": 25.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 40.8,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": false,
"right_region": [
80,
3,
40,
38
],
"exclusions": []
},
{
"elapsed_ms": 32.3,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
},
{
"elapsed_ms": 37.3,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": false,
"right_region": [
80,
3,
40,
38
],
"exclusions": []
},
{
"elapsed_ms": 30.2,
"renderable": "ChopsUpdate",
"batch_count": 0,
"current": true,
"right_collapsed": true,
"right_region": [
117,
3,
3,
38
],
"exclusions": []
}
]
}
Loading
Loading