Repository navigation
P448: derive goal controls from execution, not stored goal state - #1133
Merged
Merged
Conversation
Pairs with Core #2529: GoalExecution has no None toggle; the controlled executions are their own family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AeUaZjvChAcb6qAd6zPYmw
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P448: goal controls consume the derived execution owner
Draft, paired with Core #2529 (
636c5311d). Do not install either side alone.GoalSession already owns the bound display, execution, controls and modal lifetime. Its interactions now use that same owner for captions, visibility and actions. ToggleInteraction asks GoalExecution for its toggle/label instead of reconstructing execution from stored goal state. GoalBar's existing execution watcher updates the same control loop, including ledger-only changes.
Deleted all three ThreadGoalExecution imports/annotations and the test enum constructors; no compatibility alias, new status field or second observation path. Preserved source-binding checks, rejected-write refresh, draft/focus behavior, standby animation and collapse/resize owners. Scripted goal replies now include their matching execution instead of silently giving a present goal IdleGoalExecution.
Source evidence
Refactor-audit Package parsed all 283 production modules at Toad main 242e173, zero omissions. Related declarations, inheritance, imports, calls and consumers were read before the edit. Core's execution owner and reviewed reissue factory remain in #2529, not reimplemented here. Dynamic rebinding is outside AST proof. Patterns: IMPL-2 enum fixture constructors removed; no TIME-3 alias of the retired execution base.
Verification
Not yet run at this first checkpoint. Focused affected goal tests, real failed-ledger/active-goal paint, native stop/relaunch, fresh DM/reply and physical paired Toad acceptance remain required. No local ratchets or full suite. No installed acceptance or full P448 delivery claimed.
Assumed: