Repository navigation
Consume typed input delivery records from Core - #1170
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume Core's typed unresolved and historical input records directly. InputDeliveryDetails._records joins row.record_text(); history callbacks and retained historical rows name HistoricalInput. The decode/re-encode/string-key detour is gone from the delivery details screen.
Uses the Core record methods merged in OpenHCSDev/agent-comms#2934. uv.lock advances only agent-comms to Core main 34a2a9e3d900147f30d197e267848374d0ed5f1a. Every other package is unchanged against Toad main.
The only changed files are src/toad/widgets/input_delivery.py and uv.lock. tests/support/journals.py and tests/native/test_native_journey.py are restored exactly to origin/main. Their inputId keys belong to Pi's external journal format and stay as Pi declares them; they are outside the delivery-row migration.
src/toad/session_observation.py's history() has no return annotation; its existing return of result.historical_inputs already carries the new records. That file is unchanged.
The original delivery formatter and record methods produced byte-identical UTF-8 output for four representative rows: current sequence 65 bytes, direct input 71 bytes, uncleared historical notice 55 bytes, cleared direct historical notice 96 bytes; joined output 293 bytes. That comparison applies to the unchanged delivery formatter change, not the restored Pi fixtures.
No tests run. Assumed: origin/main f9aa367 is the requested restore baseline; Pi journal serialization stays outside this change.
Delivery history visibility is now declared by HistoryView and its frozen HiddenHistory/ShownHistory members. Initialization, invalidation, loading and clearing all assign a HistoryView. The load action reads load_offered; rendering reads inputs. update_history takes an operation returning HistoryView, so no nullable tuple or sentinel remains.
Requested grep:
That existing log-path annotation is unchanged. AST parsing and git diff --check pass; no tests run.